Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add foreman_user module #217

Closed
wants to merge 2 commits into from

Conversation

ogajduse
Copy link
Contributor

This module allows managing Foreman users. I've tested the module manually and everything should work except the following.

  • the second run of the module with the same arguments using auth_source: INTERNAL will fail with 422
  • can not change the password once is set

I haven't found support for auth_source_externals, auth_source_internals and auth_sources in Nailgun. This is something that needs to be done to provide full functionality of the foreman_user module. There is also missing support for current_password parameter while using PUT.

I haven't put any effort into creating any tests for this module yet. I will come back to it later.

@mdellweg
Copy link
Member

Just a first glance, but this looks very promising.

In case you have not yet seen it, take a look at:
https://github.com/theforeman/foreman-ansible-modules#how-to-test-modules-in-this-repository

@ogajduse
Copy link
Contributor Author

@mdellweg thanks for the first check
Added tests for this module. I won't be adding the fixtures until the following Nailgun issues will be solved:

@ogajduse
Copy link
Contributor Author

ogajduse commented Jun 6, 2019

This PR is obsoleted by #296.

@mdellweg
Copy link
Member

Thank you for the efford. #296 has been merged.

@mdellweg mdellweg closed this Jun 18, 2019
@ogajduse ogajduse deleted the foreman-user-module branch July 16, 2019 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants