Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16.4 #10

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

1.16.4 #10

wants to merge 15 commits into from

Conversation

arketec
Copy link

@arketec arketec commented Jul 19, 2021

port to 1.16

changed registration to use forge deferred registries
migration registration code to a new package
removed obsolete code
updated methods to use current methods in POTR
re-worked to use new bounding box logic
updated assets JSON to new format
move recipes to resources/data
added loot_tables for pump to drop block

please feel free to change thing or ask me to change things if you do not like them

@thebrightspark
Copy link
Owner

Thank you very much, I greatly appreciate the time and effort for someone to update this mod for me ❤️
I'll look over this and let you know of anything I feel should be changed before I merge

@thebrightspark
Copy link
Owner

thebrightspark commented Jul 19, 2021

Can you please restore the original README.md and remove the following files, as they are not necessary (I realise I need to add a licence... I'll handle that):

  • README.txt
  • LICENCE.txt
  • changelog.txt
  • The /logs directory

May be sensible to add them to the .gitignore too.

I'll have a look into the other files a little later :)

@arketec
Copy link
Author

arketec commented Jul 19, 2021

Files have been removed. Those just came with the updated MCP.

And sure, no problem on the port. I actually needed it for a mod pack I have been building and had a look over the source code and realized it would not be much of a pain to port, so just went ahead and did it.

And like I said, if there is anything I messed up (or you just don't like), let me know

@thebrightspark
Copy link
Owner

Oh sorry, missed the CREDITS.txt to be removed, if you could please :)

@arketec
Copy link
Author

arketec commented Jul 20, 2021

Sorry, was lacking sleep yesterday haha. Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants