fix: iterate over all nodes (#85) #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theHamsta
reviewed
Sep 8, 2024
`Query:iter_matches` returns a TSNode[] iterator, but it was previously being treated a single TSNode. fixes theHamsta#85
theHamsta
added a commit
that referenced
this pull request
Sep 28, 2024
After #87, this plugin became incompatible with nvim versions <= 0.9 by using the newly table parameter of iter_matches. This PR tries to avoid the parameter and tries to account that iter_matches might return either nodes or tables of nodes by coercing non-table values to singleton tables. Fixes #88
This was referenced Sep 28, 2024
theHamsta
added a commit
that referenced
this pull request
Oct 4, 2024
After #87, this plugin became incompatible with nvim versions <= 0.9 by using the newly table parameter of iter_matches. This PR tries to avoid the parameter and tries to account that iter_matches might return either nodes or tables of nodes by coercing non-table values to singleton tables. Fixes #88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query:iter_matchesreturns aTSNode[]iterator, but it was previously being treated a singleTSNode. See:h Query:iter_matches().Note: I haven't tested this change in earlier nvim versions to see if it's backwards-compatible.
fixes #85
Related: neovim/neovim#30193