Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SearchBar file to components folder #23

Merged
merged 3 commits into from
Aug 31, 2024

Conversation

joriordan332
Copy link
Collaborator

@joriordan332 joriordan332 commented Aug 29, 2024

Description

Implemented a search bar so that our user can filter their shopping list items.

Related Issue

Closed #7

Acceptance Criteria

  • A form is added to the top of the List view, above the shopping list
  • The form includes the following elements
    • A text field (with semantic <label>!) which narrows down the list as the user types
    • When there’s text in the field, some kind of button (e.g., an X) to clear the field. When the field is cleared, the list is reset to its unfiltered state.

Type of Changes

Feature

Updates

Before

image

After

image

Testing Steps / QA Criteria

-Run git pull git checkout jo-qg-shopping-list-filter
-Open with npm start
-Navigate to List to find the search bar
-Items in the list will be filtered according to the user input in the search bar

Copy link

github-actions bot commented Aug 29, 2024

Visit the preview URL for this PR (updated for commit 761be2a):

https://tcl-79-smart-shopping-list--pr23-jo-qg-shopping-list-0ua4b9g9.web.app

(expires Fri, 06 Sep 2024 14:44:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d91d9ddbda780208241c52942f544acf8e81407a

@joriordan332 joriordan332 changed the title Jo qg shopping list filter Added SearchBar file to components folder Aug 29, 2024
Copy link
Collaborator

@Hudamabkhoot Hudamabkhoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏 I just left a comment about a small change to the filtering for better accuracy.

src/components/SearchBar.jsx Outdated Show resolved Hide resolved
@joriordan332 joriordan332 merged commit 333739a into main Aug 31, 2024
2 checks passed
@joriordan332 joriordan332 deleted the jo-qg-shopping-list-filter branch September 4, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7. As a user, I want to filter my shopping list to make it easier to locate an item in the list
4 participants