Added NavLink to the nav element #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 6ba85f4): https://tcl-79-smart-shopping-list--pr18-hm-qg-nav-routing-psxf5j00.web.app (expires Mon, 19 Aug 2024 14:28:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d91d9ddbda780208241c52942f544acf8e81407a |
hariscs
approved these changes
Aug 15, 2024
Comment on lines
9
to
10
| /** | ||
| * TODO: The links defined in this file don't work! |
There was a problem hiding this comment.
As our links are working now, let's remove this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We made the nav bar functional. Replaced anchor tags with NavLink elements from react router dom.
Related Issue
Issue #3
Acceptance Criteria
• The nav element is added to the Layout component.
• Links to the "Home", "List", and "Add item" pages of the app are In the nav element.
• The links all function as expected using the NavLink component from react-router-dom.
Type of Changes
Added nav bar feature.
Updates
Before
NA, no changes to UI.
After
NA, no changes to UI.
Testing Steps / QA Criteria
• Do a
git pullandgit checkout hm-qg-nav-routing.• Open the homepage by running
npm start.• You will find a nav bar with 3 links at the bottom. As you click each link, the url and the hello message should change accordingly.