-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A way for an new user to understand how the app functions #41
Conversation
Visit the preview URL for this PR (updated for commit 33ffcf1): https://tcl-77-smart-shopping-list--pr41-bb-app-func-new-user-dvajljf2.web.app (expires Mon, 07 Oct 2024 01:01:07 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72 |
…bout page with button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job Brianna! Love the shout outs haha. Added my comments and excited to see how this feature may expand in the final MVP!
…el based on if needs to sign up or in
…ing merge conflicts
…p comp since didn't get them in conflict resolve
…page since it is not a protected route it was just staying on about
…d to the view fully and they were always showing
Description
This code adds 2 main pieces at this time, an
UnauthenticatedNavBar
and anAbout
page, to give an opportunity for a new user to understand what the application does before signing up. Because we are in a process of framework and design choices, I did take an approach more similar to a "how-to" section of the application. As mentioned in issue #42 I think a carousel would be really nice to have instead of just the list of "how-tos" but I think getting the style choices figured out to see if they have any components to use beforehand will allow us to better now what we want to use for that.Related Issue
Closes #39
Acceptance Criteria
unauthenticated
homepage.unauthenticated
homepage, a unauthenticatedNavBar
component to get to maybe a sample list would be useful.unauthenticated
user, a visitor, to get a general understanding of how the app works and what they can do with it.Type of Changes
Updates
Before
Screen.Recording.2024-09-25.at.2.30.47.AM.mov
After
Screen.Recording.2024-09-25.at.2.31.24.AM.mov
Testing Steps / QA Criteria
git pull origin bb/app-func-new-user
and check that branch out with git checkout `bb/app-func-new-usernpm ci
to install the newly added dependencies locally andnpm start
to launch the app.tsc --noEmit --watch
to see any type issue.sign out
.unauthenticated
home page is seen.learn more
button or theabout
nav link in the nav bar to navigate to the new about page.Next TODO
With the design convo that happened at office hours it seems like we have a direction for CSS framework and the
bootstrap
/react-bootstrap
has a carousel component in it that would be awesome to use for this so didn't want to commit to a package before doing that.- Maybe a stretch goal maybe not but it may be nice to give two touch points of understanding the functionality of the app