Skip to content

Commit

Permalink
a nit to Crystalline's test/calc_bandreps.jl: special casing no lon…
Browse files Browse the repository at this point in the history
…ger needed (#59 has been resolved earlier)
  • Loading branch information
thchr committed Nov 14, 2024
1 parent 9ed0512 commit bbcb2c3
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions test/calc_bandreps.jl
Original file line number Diff line number Diff line change
Expand Up @@ -79,17 +79,10 @@ end
# so, for these cases, we cannot do a one-to-one comparison (but we can at
# least test whether the reference Bilbao vector occurs in the set of
# computed band representation vectors)
if brʳ.sitesym ("222", "mmm", "mm2", "-4m2")
if brʳ.sitesym ("222", "mmm", "mm2")
brᶜ = brsᶜ[idx]
@test Vector(brᶜ) == brʳ[irʳ²ᶜ_perm]
@test dim(brᶜ) == dim(brʳ)
elseif brʳ.sitesym == "-4m2"
# this is a special case: in principle, it is possible to uniquely
# assign the irrep labels, but we currently assign ones that are
# different from those in Bilbao (see issue #59)
# FIXME: remove this here and above once #59 is resolved
@test brʳ[irʳ²ᶜ_perm] Vector.(brsᶜ)
continue
else
# simply test that the reference Bilbao _vector_ is in the set of
# computed EBRs
Expand Down

0 comments on commit bbcb2c3

Please sign in to comment.