Docs: Remove quote from replica label #8075
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove quotes from the
--deduplication.replica-labelexamples for the Thanos Compactor docs, this is misleading as the quotes end up being assumed to be part of the replica label, which is unintended.Also referenced and suggested in this issue: #6410
Verification
Not verified. Could not get a go dev environment to work to run the
make docscommand, encountered several issues following CONTRIBUTING.md, though I don't know enough about go development to determine if it's just a case of PEBKAC.Hoping the build system will be able to validate it for me, if not can just bin this PR as I'm unable to commit further time to it, sorry!