Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the bucketed bytes pool #7756

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

fpetkovski
Copy link
Contributor

@fpetkovski fpetkovski commented Sep 17, 2024

Now that we have generics, we can generalize the bucketed bytes pool to be used with slices of any type T.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Now that we have generics, we can generalize the bucketed bytes pool
to be used with slices of any type T.

Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 17, 2024
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Are you planning o. Pooling something else?

@fpetkovski
Copy link
Contributor Author

fpetkovski commented Sep 17, 2024

I wanted to use the pool in #7659.

@fpetkovski fpetkovski merged commit 2bdb909 into thanos-io:main Sep 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants