avoid fmt.Errorf calls for an error that is never read (reduce useless memory allocs) #2349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While chasing memory allocations (heavy usage of WASM modules, leading to thrashing golang garbage collector ...),
I found a lot of fmt.Errorf() called, without any error resurfacing.
The content of these errors are always ignored, so it makes more sense to reuse the same
error
object, saving a lot of object memory allocations.