add 'summary' element to list of focusable selectors #1163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
add
summary
element to list of focusable selectorsWhy:
in all major browsers, the
summary
element is focusable via keyboard (when it's a direct descendent of adetails
element)making this change will allow
user.tab()
(viagetTabDestination()
) to focussummary
elements; which matches the behavior found in all major browsers.document.activeElement
results in the<summary>
elementdocument.activeElement
How:
Checklist:
what about #947 and what about
details
being marked as "interactive content" per the spec, but summary technically is not?i understand there's some nuance to
<details>
without a<summary>
and thatdetails
is the one that marked as "interactive content", but what reflects reality is that...summary
element as interactive (see above); and never thedetails
element itself<summary>
, where as<details>
has an implicit role of "group" (this more or less matches what's seen in devtools)summary
element (such asdetails
without a descendentsummary
), this doesn't change the most common case wheredetails > summary
is focusable