Skip to content

Conversation

@wundii
Copy link

@wundii wundii commented Oct 1, 2025

Hi,

WaitForHttp is runs outside the container and cannot access the internal port if it differs from the external port. With this solution, the external dynamic port is resolved via the specified internal port.

integration + cs + phpstan was executed successfully before the PR

@shyim shyim requested a review from rw4lll October 2, 2025 04:06
@rw4lll
Copy link
Collaborator

rw4lll commented Oct 16, 2025

Hi @wundii,

thank you for the PR. Could you please take a look at this PR?
As far as I remember, we introduced something similar in one of the latest releases. Can it be the duplicate?

@wundii
Copy link
Author

wundii commented Oct 17, 2025

Hi @rw4lll,

Thanks for the info. I've given it some more thought. If you don't pass a port to WaitForHttp, it works for the first port. In our case, we want to refer to a specific port in WaitForHttp, as there may be more than one. In this case, the resolvePort method no longer works. I have revised it again and hope that it is now easier to read for our problem. I have also added another test to check the firstMappedPort and MappedPort for the two variants with WaitForHttp.

@wundii
Copy link
Author

wundii commented Nov 25, 2025

Hi @rw4lll and @shyim,

Would it be possible to review this PR so that we can remove our workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants