feat: Update to Docker Engine v29 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HofmeisterAn
force-pushed
the
feature/add-docker-engine-v29-support
branch
from
e673c0e to
b4bdcef
Compare
HofmeisterAn
commented
Nov 24, 2025
Comment on lines
+32
to
+36
| // TODO: This type is no longer public (the JSON bool field was removed). | ||
| // Only the interface is available. For now, create an empty type so the | ||
| // code compiles, and we'll figure out the proper implementation later: | ||
| // https://github.com/moby/moby/blob/master/client/image_load.go | ||
| type ImageLoadResult struct{} |
Collaborator
Author
There was a problem hiding this comment.
TODO: Fix this comment.
Collaborator
Author
There was a problem hiding this comment.
Hi @mdelapenya, could you please take a look at the Go changes in tools/specgen? It's basically just a type mapping, and I want to make sure I replaced the old types with the correct new ones. See:
csharptype.gomodeldefs.goresttag.gospecgen.go
HofmeisterAn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the Docker Engine API to version 29. Be aware that version 29 includes breaking changes and reorganizes the Go modules.
Note: This PR includes breaking changes. The project doesn't provide backward compatibility yet. This update makes Docker.DotNet compatible with Docker Engine v29 (API version 1.52). If you're running an older API version or downgrade the API version, some request and response models might be missing properties that were removed (deprecated) in v29.