add diagram showing system overview #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agbpatro
reviewed
Apr 19, 2024
|
Why are we documentating deprecated flow? |
|
@ThomasAlxDmy this is the required flow at this point. This will be updated once the new flow is available. |
patrickdemers6
force-pushed
the
architecture-diagram
branch
from
ad62566
to
dd0d584
Compare
aaronpkahn
approved these changes
Apr 22, 2024
agbpatro
reviewed
Apr 22, 2024
| @@ -79,3 +79,6 @@ image-gen: | |||
| docker save $(ALPHA_IMAGE_NAME) | gzip > $(ALPHA_IMAGE_COMPRESSED_FILENAME).tar.gz | |||
|
|
|||
| .PHONY: test build vet linters install integration image-gen generate-protos generate-golang generate-python generate-ruby clean | |||
|
|
|||
| doc-images: | |||
There was a problem hiding this comment.
this should be above PHONY and most likely needs to be part of PHONY
8 tasks
patrickdemers6
force-pushed
the
architecture-diagram
branch
from
dd0d584
to
dd67419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a diagram which shows system architecture.
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: