Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Detailed Charge State field #161

Closed
wants to merge 1 commit into from
Closed

Conversation

agbpatro
Copy link
Collaborator

Description

Adding a detailed charge state in the payload
If the value is present in string, convert into respective enum

Fixes # (issue)
#123

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.
  • I have added/updated integration tests to cover my changes.

@jbanyer
Copy link

jbanyer commented May 9, 2024

FYI I tried to use this new field, however when I attempt to reference this field in a vehicle configuration (POST /api/1/vehicles/fleet_telemetry_config) I receive the following error:

{
  response: null,
  error: 'Unknown field DetailedChargeState',
  error_description: '',
  txid: 'd4cd7d67edf5e099f0f4e46d7e7af102'
}

}
}

// parseDetailedChargeState parses a location string (such as "Disconnected") into a *proto.Location type.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is slightly incorrect, "parses a location", should be "parses a charge state string"....

@stx
Copy link

stx commented Aug 12, 2024

@agbpatro Any ETA on this? Super important field.

Adding a detailed charge state in the payload
If the value is present in string, convert into respective enum
@patrickdemers6
Copy link
Collaborator

Closing this as it's addressed in #206. Vehicles will be capable of sending this field in a future firmware release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants