test: add accessibility test #1668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ No tests were found related to the files changed |
LukasLohoff
approved these changes
Jun 28, 2024
package.json
Outdated
| @@ -42,6 +42,7 @@ | |||
| "not IE 11" | |||
| ], | |||
| "dependencies": { | |||
| "@axe-core/playwright": "^4.9.1", | |||
There was a problem hiding this comment.
could you check if this can be a devDependency?
There was a problem hiding this comment.
Thank you, yes, I moved both to devDependencies.
Co-authored-by: Lukas Lohoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This merge requests imports an accessibility test (e2e-test) from terrestris/shogun-e2e-tests#8 in order to test the gis-client for accessibility issues based on the Web Content Accessibility Guidelines (WCAG).
The test passes when no violations (issues that fail WCAG standards) are reported.
TODO:
terrestris/shogun-e2e-tests#8 hast to be released first in order for this to work.