Skip to content

Commit

Permalink
Don't create ingress rule if worker security group exists (#715)
Browse files Browse the repository at this point in the history
  • Loading branch information
andjelx authored and max-rocket-internet committed Jan 28, 2020
1 parent 905d9f0 commit de90ff5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
## [[v8.?.?](https://github.com/terraform-aws-modules/terraform-aws-eks/compare/v8.1.0...HEAD)] - YYYY-MM-DD]

- Include ability to configure custom os-specific command for waiting until kube cluster is healthy (@sanjeevgiri)
- Disable creation of ingress rules if worker nodes security groups are exists (@andjelx)

# History

Expand Down
2 changes: 1 addition & 1 deletion cluster.tf
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ resource "aws_security_group_rule" "cluster_egress_internet" {
}

resource "aws_security_group_rule" "cluster_https_worker_ingress" {
count = var.create_eks ? 1 : 0
count = var.worker_security_group_id == "" && var.create_eks ? 1 : 0
description = "Allow pods to communicate with the EKS cluster API."
protocol = "tcp"
security_group_id = local.cluster_security_group_id
Expand Down

0 comments on commit de90ff5

Please sign in to comment.