Change enum identifiers for C++ compatibility #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I use the library for a C++ project. When compiling I get an error because the identifier of the enum (
tmcXXXX_regaddr_t
) is the same as the name of the type in the line directly before it.In C the identifier of an enum is irrelevant (except for clarity), but in C++ it is relevant. By changing the identifier, it is also possible to use the library with a C++ compiler.
Despite the change, it is still clear that these are the addresses and that they are used with the type
tmcXXXX_regaddr_t
.Since the affected files are header files, it is not possible to specifically compile the affected file with a C compiler.
jjw2202