Add missing linter/formatter config files #968
+45
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `.style.yapf`.
This adds a configuration file for `clang-format`. It's based on the one from TensorFlow, with the addition of a section for Protobufs (which `clang-format` is also able to format).
Collaborator
|
We already have formatting scripts for both cpp and python, I don't know if we need these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a couple of files for tools used by scripts in
./scripts/:A config file for YAPF, copied from the TensorFlow repo. Even though it's very simple, it's useful enough because it prevents people getting incorrect results if they decide to run
yapfdirectly. (The default used in this project and TensorFlow is Google style, but that's not the YAPF default.)A config file for clang-format. This is based on the one from the TensorFlow repo and adds a section for Protobufs, because clang-format can format protobuf files too.