Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings of c++ compilation #476

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Fix warnings of c++ compilation #476

wants to merge 11 commits into from

Conversation

jaeyoo
Copy link
Member

@jaeyoo jaeyoo commented Feb 7, 2021

@jaeyoo
Copy link
Member Author

jaeyoo commented Feb 8, 2021

Please merge this one earlier than #477 if possible

@zaqqwerty
Copy link
Contributor

zaqqwerty commented Aug 25, 2021 •
edited
Loading

Seems stale at this point, do you wish to update or should we close for now?

@jaeyoo
Copy link
Member Author

jaeyoo commented Aug 25, 2021

Seems stale at this point, do you wish to update or should we close for now?

Let me update it :)

@jaeyoo jaeyoo requested a review from zaqqwerty August 26, 2021 00:34
zaqqwerty
zaqqwerty suggested changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@zaqqwerty zaqqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, have a couple questions. If the resolution of the static function stuff is unclear we can merge the rest without touching util_qsim, this will just leave unused function warnings, which is a big improvement :)

tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated Show resolved Hide resolved
tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated Show resolved Hide resolved
tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated Show resolved Hide resolved
tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated Show resolved Hide resolved
tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated Show resolved Hide resolved
tensorflow_quantum/core/ops/math_ops/tfq_inner_product.cc Outdated Show resolved Hide resolved
scripts/test_all.sh Outdated Show resolved Hide resolved
jaeyoo pushed a commit to jaeyoo/quantum that referenced this pull request Mar 30, 2023
@sergeisakov
Merge pull request tensorflow#476 from quantumlib/change-env-var-name
79c8ab4 
Change environment variable name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaqqwerty zaqqwerty zaqqwerty requested changes

@MichaelBroughton MichaelBroughton Awaiting requested review from MichaelBroughton

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaeyoo @zaqqwerty