feat: add transaction builders and vm.executeTransaction binding #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Solidity libraries for building and RLP-encoding transactions:
- `LegacyTransactionLib` - Legacy transactions (no type prefix)
- `Eip1559TransactionLib` - EIP-1559 transactions (type 0x02)
- `Eip7702TransactionLib` - EIP-7702 transactions (type 0x04)
- `TempoTransactionLib` - Tempo transactions (type 0x76)
Also adds `VmRlp` and `VmExecuteTransaction` interfaces for the
`vm.toRlp()` and `vm.executeTransaction()` cheatcodes.
## Usage
```solidity
using LegacyTransactionLib for LegacyTransaction;
VmRlp rlp = VmRlp(address(vm));
VmExecuteTransaction txVm = VmExecuteTransaction(address(vm));
bytes memory rawTx = LegacyTransactionLib.create()
.withNonce(0)
.withGasPrice(100)
.withGasLimit(100000)
.withTo(target)
.withData(calldata)
.encodeWithSignature(rlp, v, r, s);
bytes memory result = txVm.executeTransaction(rawTx);
```
onbjerg
force-pushed
the
onbjerg/push-qmqxovnlmvyu
branch
from
722521d to
aadacce
Compare
Collaborator
|
Approach lgtm here but current vm.executeTransaction zero's out gas price which is not in line with the expectation; my suggestion is to not zero out (we rely on gas paid for some types of assertions). See: https://github.com/tempoxyz/tempo-foundry/pull/183/changes#r2685929170 |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Solidity libraries for building and RLP-encoding transactions:
LegacyTransactionLib- Legacy transactions (no type prefix)Eip1559TransactionLib- EIP-1559 transactions (type 0x02)Eip7702TransactionLib- EIP-7702 transactions (type 0x04)TempoTransactionLib- Tempo transactions (type 0x76)Also adds
VmRlpandVmExecuteTransactioninterfaces for thevm.toRlp()andvm.executeTransaction()cheatcodes.Usage