[Reset] Add AllowChildReconnect flag in task generator #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
approved these changes
Jan 24, 2025
pdoerner
pushed a commit
that referenced
this pull request
Jan 29, 2025
## What changed? Added a `StartChildExecutionTask.AllowChildReconnect` bool flag to mark the task at the time of reset. This flag is used to determine if we want to attempt to reconnect the child or not (instead of just checking if the workflow was reset) ## Why? In `transferQueueActiveTaskExecutor.processStartChildExecution()` I was checking the condition `mutableState.IsResetRun()` before attempting to reconnect to children. The problem is `mutableState.IsResetRun()` is true for the rest of the lifetime of the workflow. So if the workflow starts another instance of the same child somewhere down the line, we will reconnect to the previously completed instance of the child. So added an explicit flag in StartChildExecutionTask to determine if we should reconnect to the child or start a new instance. ## How did you test it? Existing unit test + manual testing. ## Potential risks N/A. The feature is gated behind a feature flag. ## Documentation N/A ## Is hotfix candidate? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a
StartChildExecutionTask.AllowChildReconnectbool flag to mark the task at the time of reset. This flag is used to determine if we want to attempt to reconnect the child or not (instead of just checking if the workflow was reset)Why?
In
transferQueueActiveTaskExecutor.processStartChildExecution()I was checking the conditionmutableState.IsResetRun()before attempting to reconnect to children. The problem ismutableState.IsResetRun()is true for the rest of the lifetime of the workflow. So if the workflow starts another instance of the same child somewhere down the line, we will reconnect to the previously completed instance of the child. So added an explicit flag in StartChildExecutionTask to determine if we should reconnect to the child or start a new instance.How did you test it?
Existing unit test + manual testing.
Potential risks
N/A. The feature is gated behind a feature flag.
Documentation
N/A
Is hotfix candidate?
No