Retry handover error during graceful failover #7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yycptt
reviewed
Dec 23, 2024
| err := ni.checkReplicationState(nsEntry, info.FullMethod) | ||
| if err != nil { | ||
| var nsErr error | ||
| nsEntry, nsErr = ni.namespaceRegistry.RefreshNamespaceById(nsEntry.ID()) |
There was a problem hiding this comment.
hmmm this will keep refreshing the namespace? I mean all requests will perform a refresh upon retry.
also if the handover error is from history service then the refresh here is unnecessary
| return err | ||
| } | ||
| return ni.checkReplicationState(namespaceEntry, fullMethod) | ||
| // Only retry on ErrNamespaceHandover, other errors will be handled by the retry interceptor | ||
| err := backoff.ThrottleRetryContext(ctx, op, handoverRetryPolicy, common.IsNamespaceHandoverError) |
There was a problem hiding this comment.
I also worry this will cause server api latency alert to fire during the handover, we should probably exclude this backoff from nouserlatency metric.
| return err | ||
| } | ||
| return ni.checkReplicationState(namespaceEntry, fullMethod) | ||
| // Only retry on ErrNamespaceHandover, other errors will be handled by the retry interceptor |
There was a problem hiding this comment.
shall we just let retry interceptor handle the error? and this interceptor just block until ns is no longer in handover state?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Retry handover error during graceful failover
Why?
Namespace handover error is transient during graceful failover we can retry on this error.
This is the best effort to reduce the returned error. If the retry exhausted, it still return the handover to caller.
The backoff retry handles the context deadline duration and retry.
How did you test it?
Unit tests.
Potential risks
Documentation
Is hotfix candidate?