[Deployments] Sync workflow before activity tqs and batch updates #7003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahabT
reviewed
Dec 19, 2024
| }) | ||
| } | ||
| if workflow.GetVersion(ctx, "syncToTaskQueues", workflow.DefaultVersion, 0) == workflow.DefaultVersion { | ||
| err = d.syncToTaskQueues1(ctx) |
There was a problem hiding this comment.
Nit: should we call these syncToTaskQueues0 and syncToTaskQueues1 to match the version?
| // Sync and wait for workflow task queues, then activity task queues, to ensure that | ||
| // workflows don't bounce between deployments due to activity/wft starts. | ||
| enumspb.TASK_QUEUE_TYPE_WORKFLOW, | ||
| enumspb.TASK_QUEUE_TYPE_ACTIVITY, |
There was a problem hiding this comment.
We want to support Nexus tasks too. they should be synced with activities I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
How did you test it?
existing tests
Potential risks
the workflow logic change is guarded with GetVersion call