Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert old and inline integration tests #1583

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

THardy98
Copy link
Contributor

@THardy98 THardy98 commented Dec 11, 2024

What was changed

Refactoring old integration tests to use integration helpers.
Extended existing integration helpers to allow for configurable test contexts.

Why?

Establish more consistency with our testing.

Checklist

I'm treating this like a remaining TODO list:

  • there are still a number of testing files that need to be converted to use the integration testing helpers (for separate PRs)
  • we would like to organize our test workflows, activities, and definitions into targeted concerns (i.e. child workflows, signal workflows, etc.). This will make it easier to discern the purpose of each testing file and provide some visibility into our test coverage (separate PR)

  1. Closes [Feature Request] Complete conversion of old style integration tests #1569

  2. How was this tested:
    Existing tests do not break

  3. Any docs updates needed?
    No

@THardy98 THardy98 requested a review from a team as a code owner December 11, 2024 07:02
@THardy98 THardy98 marked this pull request as draft December 11, 2024 07:02
@THardy98 THardy98 requested a review from mjameswh December 11, 2024 07:02
@THardy98 THardy98 force-pushed the convert-old-and-inline-integration-tests branch from 87e4b73 to 7e0aac3 Compare December 11, 2024 07:05
@THardy98 THardy98 changed the title Convert old and inline integration tests [DRAFT][IN-PROGRESS] Convert old and inline integration tests Dec 11, 2024
@THardy98 THardy98 force-pushed the convert-old-and-inline-integration-tests branch from d396acb to 842a0bf Compare December 11, 2024 07:08
@THardy98
Copy link
Contributor Author

THardy98 commented Dec 11, 2024

The main change is the pattern used in test-integration-new (I'll rename this file) to run tests over multiple test environments, and the supporting changes in helpers-integration.

Aside from that it's mostly converting tests to use the integration helpers and removing a number of single-use workflows.

I've left a small comment in workflows/index.ts noting that the filenames could make for a good start in terms of organizing our tests into more specific areas (the filenames are usually prefixed with these areas, like child, or signal, or cancel).

We can also use the shared workflows imported in test-integration-new to identify test files that are potentially similar (or at least common testing areas across multiple files), which we can then group or synthesize. As we convert other test files in this manner, it'll be increasingly clear where the commonalities lie.

@THardy98 THardy98 force-pushed the convert-old-and-inline-integration-tests branch 3 times, most recently from 9193dc1 to 2d637ad Compare December 18, 2024 14:32
@THardy98 THardy98 force-pushed the convert-old-and-inline-integration-tests branch from 60265cc to 670f8bc Compare December 19, 2024 17:02
@THardy98 THardy98 changed the title [DRAFT][IN-PROGRESS] Convert old and inline integration tests Convert old and inline integration tests Dec 19, 2024
@THardy98 THardy98 marked this pull request as ready for review December 19, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Complete conversion of old style integration tests
1 participant