Skip to content

Commit

Permalink
Fix a floating error in the WorkerRestart test (#542)
Browse files Browse the repository at this point in the history
  • Loading branch information
igancev authored Jan 1, 2025
1 parent b9346fa commit 6598397
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions tests/Acceptance/Harness/Update/WorkerRestartTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
use Temporal\Activity\ActivityMethod;
use Temporal\Activity\ActivityOptions;
use Temporal\Client\WorkflowStubInterface;
use Temporal\Exception\Failure\ApplicationFailure;
use Temporal\Tests\Acceptance\App\Attribute\Stub;
use Temporal\Tests\Acceptance\App\Runtime\RRStarter;
use Temporal\Tests\Acceptance\App\TestCase;
Expand All @@ -32,7 +31,6 @@ public static function check(
ContainerInterface $c,
RRStarter $runner,
): void {
$c->get(StorageInterface::class)->set(KV_ACTIVITY_BLOCKED, true);
$handle = $stub->startUpdate('do_activities');

# Wait for the activity to start.
Expand Down Expand Up @@ -95,9 +93,8 @@ public function blocks(): string
$this->kv->set(KV_ACTIVITY_STARTED, true);

do {
$blocked = $this->kv->get(KV_ACTIVITY_BLOCKED);
$blocked = $this->kv->get(KV_ACTIVITY_BLOCKED, true);

\is_bool($blocked) or throw new ApplicationFailure('KV BLOCKED key not set', 'KvNotSet', true);
if (!$blocked) {
break;
}
Expand Down

0 comments on commit 6598397

Please sign in to comment.