Update Java SDK for Temporal Sever v1.26.2 #2357
Conversation
Quinn-With-Two-Ns
changed the title
| @@ -189,7 +189,14 @@ private TemporalFailure failureToExceptionImpl(Failure failure, DataConverter da | |||
| } | |||
| case FAILUREINFO_NOT_SET: | |||
| default: | |||
| throw new IllegalArgumentException("Failure info not set"); | |||
| // All unknown types are considered to be retryable ApplicationError. | |||
There was a problem hiding this comment.
I checked all other SDKs and the Java SDK was the only SDK that was throwing an exception here instead of converting to an application failure
| @@ -58,17 +58,6 @@ public void syncOperationImmediatelyCancelled() { | |||
| "operation canceled before it was started", canceledFailure.getOriginalMessage()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void syncOperationCancelled() { | |||
There was a problem hiding this comment.
Removed this test since the Server dropped support for cancelling failing sync operations
| Assert.assertEquals( | ||
| "operation terminated", | ||
| ((ApplicationFailure) nexusFailure.getCause()).getOriginalMessage()); | ||
| // TODO: Test server needs to be fixed to return the correct type |
There was a problem hiding this comment.
If this TODO is to be done separately, can we open an issue and reference it here?
| @@ -86,6 +87,17 @@ | |||
| import org.slf4j.LoggerFactory; | |||
|
|
|||
| class TestWorkflowMutableStateImpl implements TestWorkflowMutableState { | |||
| static final Failure FAILED_UPDATE_ON_WF_COMPLETION = | |||
There was a problem hiding this comment.
Do we have a test confirming that this at least looks mostly like the real server's version? Unsure if Java has tests against actual server and test server with the same code, but I just want to make sure if/when this changes server side we can catch it here.
There was a problem hiding this comment.
Yeah I can do that
There was some changes in Temporal Sever v1.26.2. This PR updates the Java SDK tests and test server to handle the new behaviour