Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflowcheck - initial support for Java static analyzer #2356

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cretz
Copy link
Member

@cretz cretz commented Dec 26, 2024

What was changed

Added initial temporal-workflowcheck project. This is currently considered "beta". See the README for more about the project.

TODO in the near future:

  • Turn the TODO at the bottom of temporal-workflowcheck/README.md into a set of issues
  • After we have published our first release of this...
    • Update primary README with link to the project in the child dir
    • Update the 3 sample projects herein to reference the project
    • Update samples-java to incorporate workflowcheck

}

// Need all-in-one JAR
shadowJar {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike the -shaded project, we just need the -all.jar this generates, and we only have one real dependency anyways

Comment on lines +3 to +5
// Add the workflowcheck project as a composite build. We are only doing this
// for the sample, normally this is not needed.
includeBuild '../../../'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the other two samples will be updated when a version of this project is published

System.err.println("Unrecognized argument: " + invalidArg);
}

System.err.println("Analyzing classpath for classes with workflow methods...");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I do System.err here and System.out below, probably just need to pick one

@cretz cretz marked this pull request as ready for review December 26, 2024 21:12
@cretz cretz requested a review from a team as a code owner December 26, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant