Message handlers sample #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
safe_message_handlers
branch
from
997f3f5 to
15307fe
Compare
mjameswh
reviewed
Jul 12, 2024
dandavison
force-pushed
the
safe_message_handlers
branch
from
52a908f to
b1801b5
Compare
mjameswh
reviewed
Jul 12, 2024
updates_and_signals/safe_message_handlers/src/run-simulation.ts
Outdated
Show resolved
Hide resolved
dandavison
force-pushed
the
safe_message_handlers
branch
from
4056072 to
f1d4999
Compare
mjameswh
reviewed
Jul 12, 2024
dandavison
force-pushed
the
safe_message_handlers
branch
from
f1d4999 to
54a300c
Compare
We want to avoid encouraging users to poll from an entity workflow loop, even if the interval is long in the example.
dandavison
force-pushed
the
safe_message_handlers
branch
from
b8c20e8 to
1a7c8c7
Compare
|
@mjameswh I think I've addressed everything here. Over to you again. |
mjameswh
reviewed
Aug 30, 2024
mjameswh
reviewed
Aug 30, 2024
mjameswh
reviewed
Aug 30, 2024
updates_and_signals/safe_message_handlers/src/cluster-manager.ts
Outdated
Show resolved
Hide resolved
mjameswh
reviewed
Aug 30, 2024
updates_and_signals/safe_message_handlers/src/cluster-manager.ts
Outdated
Show resolved
Hide resolved
mjameswh
reviewed
Aug 30, 2024
updates_and_signals/safe_message_handlers/src/cluster-manager.ts
Outdated
Show resolved
Hide resolved
mjameswh
reviewed
Aug 30, 2024
updates_and_signals/safe_message_handlers/src/cluster-manager.ts
Outdated
Show resolved
Hide resolved
mjameswh
reviewed
Aug 30, 2024
mjameswh
reviewed
Aug 30, 2024
updates_and_signals/safe_message_handlers/src/test/workflows.test.ts
Outdated
Show resolved
Hide resolved
mjameswh
reviewed
Aug 30, 2024
updates_and_signals/safe_message_handlers/src/test/workflows.test.ts
Outdated
Show resolved
Hide resolved
mjameswh
reviewed
Aug 30, 2024
mjameswh
reviewed
Aug 30, 2024
dandavison
commented
Sep 4, 2024
There was a problem hiding this comment.
Thanks for the careful reviewing @mjameswh! Addressed those.
updates_and_signals/safe_message_handlers/src/cluster-manager.ts
Outdated
Show resolved
Hide resolved
updates_and_signals/safe_message_handlers/src/cluster-manager.ts
Outdated
Show resolved
Hide resolved
updates_and_signals/safe_message_handlers/src/cluster-manager.ts
Outdated
Show resolved
Hide resolved
updates_and_signals/safe_message_handlers/src/test/workflows.test.ts
Outdated
Show resolved
Hide resolved
updates_and_signals/safe_message_handlers/src/cluster-manager.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes temporalio/sdk-typescript#1446
This is based on @drewhoskins-temporal's Python sample: temporalio/samples-python#123, and uses https://github.com/DirtyHairy/async-mutex.
Note that this moves husky actions to pre-push; they are too disruptive in pre-commit for people who commit frequently, including via non-CLI clients that would have to be configured to pass
--no-verify.