Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom_converter and infrequent_polling samples #95

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Fix custom_converter and infrequent_polling samples #95

merged 3 commits into from
Nov 14, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Nov 9, 2023

What was changed

Fix issue with shared code in custom converter sample (and added test) and removed loop from infrequent polling sample

Checklist

  1. Closes [Bug] custom_converter fails due to type hint assertion in sandbox #93
  2. Closes [Bug] Infrequent polling activity should not loop #90

@cretz cretz requested a review from a team November 9, 2023 15:42
@cretz cretz merged commit 68ba233 into temporalio:main Nov 14, 2023
8 checks passed
@cretz cretz deleted the sample-fixes branch November 14, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cretz @Sushisource