-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow Update and Signal handlers concurrency sample #123
Changes from 10 commits
5d0307d
bca534a
8b0a6ed
fb7b32f
42d1f12
c96f06d
6944099
ec1fb89
dd58c64
37e56ed
a1506b1
2cad3dd
d5db7d7
f39841c
344d694
fc74a69
0b84c25
c8e9075
4fc6dac
3ba8882
f47369e
5dc6185
5b45b21
ce4d384
52429bd
74867f1
c6bdd12
62f24a2
d933042
31e2d59
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import uuid | ||
|
||
from temporalio import common, workflow | ||
from temporalio.client import Client | ||
from temporalio.worker import Worker | ||
|
||
from updates_and_signals.atomic_message_handlers.activities import ( | ||
allocate_nodes_to_job, | ||
deallocate_nodes_for_job, | ||
find_bad_nodes, | ||
) | ||
from updates_and_signals.atomic_message_handlers.starter import do_cluster_lifecycle | ||
from updates_and_signals.atomic_message_handlers.workflow import ( | ||
ClusterManagerInput, | ||
ClusterManagerWorkflow, | ||
) | ||
|
||
|
||
async def test_atomic_message_handlers(client: Client): | ||
task_queue = f"tq-{uuid.uuid4()}" | ||
async with Worker( | ||
client, | ||
task_queue=task_queue, | ||
workflows=[ClusterManagerWorkflow], | ||
activities=[allocate_nodes_to_job, deallocate_nodes_for_job, find_bad_nodes], | ||
): | ||
cluster_manager_handle = await client.start_workflow( | ||
ClusterManagerWorkflow.run, | ||
ClusterManagerInput(), | ||
id=f"ClusterManagerWorkflow-{uuid.uuid4()}", | ||
task_queue=task_queue, | ||
start_signal="start_cluster", | ||
) | ||
await do_cluster_lifecycle(cluster_manager_handle, delay_seconds=1) | ||
result = await cluster_manager_handle.result() | ||
assert result.max_assigned_nodes == 12 | ||
assert result.num_assigned_nodes == 0 |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The primary README at the root of this repo should be updated to reference this sample |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Atomic message handlers | ||
|
||
This sample shows off important techniques for handling signals and updates, aka messages. In particular, it illustrates how message handlers can interleave and how you can manage that. | ||
|
||
* Here, using workflow.wait_condition, signal and update handlers will only operate when the workflow is within a certain state--between cluster_started and cluster_shutdown. | ||
* You can run start_workflow with an initializer signal that you want to run before anything else other than the workflow's constructor. This pattern is known as "signal-with-start." | ||
* Message handlers can block and their actions can be interleaved with one another and with the main workflow. This can easily cause bugs, so we use a lock to protect shared state from interleaved access. | ||
* Message handlers should also finish before the workflow run completes. One option is to use a lock. | ||
* An "Entity" workflow, i.e. a long-lived workflow, periodically "continues as new". It must do this to prevent its history from growing too large, and it passes its state to the next workflow. You can check `workflow.info().is_continue_as_new_suggested()` to see when it's time. Just make sure message handlers have finished before doing so. | ||
|
||
To run, first see [README.md](../../README.md) for prerequisites. | ||
|
||
Then, run the following from this directory to run the sample: | ||
|
||
```bash | ||
poetry run python worker.py | ||
poetry run python starter.py | ||
``` | ||
|
||
This will start a worker to run your workflow and activities, then start a ClusterManagerWorkflow and put it through its paces. |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,45 @@ | ||||||
import asyncio | ||||||
from dataclasses import dataclass | ||||||
from typing import List | ||||||
|
||||||
from temporalio import activity | ||||||
|
||||||
|
||||||
@dataclass(kw_only=True) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Probably not needed, but no big deal There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I prefer named arguments in general for 2+ parameters. Cuts down on callsite bugs and makes them clearer. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can still use named arguments. We use them in lots of places, but since we're the only users of them we don't need to set this setting to force us to use them. Also, we have a CI check for our samples in 3.8 and I don't think this came about until 3.10 (we can look into relaxing our CI version constraints though). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, too bad. I'd rather people who pattern-match off of this sample be directed toward best practices. Will remove for now. I wonder if we have stats on python versions people actually use in the wild? |
||||||
class AllocateNodesToJobInput: | ||||||
nodes: List[str] | ||||||
task_name: str | ||||||
|
||||||
|
||||||
@activity.defn | ||||||
async def allocate_nodes_to_job(input: AllocateNodesToJobInput) -> List[str]: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This return type hint seems invalid (same with some other functions) |
||||||
print(f"Assigning nodes {input.nodes} to job {input.task_name}") | ||||||
await asyncio.sleep(0.1) | ||||||
|
||||||
|
||||||
@dataclass(kw_only=True) | ||||||
class DeallocateNodesForJobInput: | ||||||
nodes: List[str] | ||||||
task_name: str | ||||||
|
||||||
|
||||||
@activity.defn | ||||||
async def deallocate_nodes_for_job(input: DeallocateNodesForJobInput) -> List[str]: | ||||||
print(f"Deallocating nodes {input.nodes} from job {input.task_name}") | ||||||
await asyncio.sleep(0.1) | ||||||
|
||||||
|
||||||
@dataclass(kw_only=True) | ||||||
class FindBadNodesInput: | ||||||
nodes_to_check: List[str] | ||||||
|
||||||
|
||||||
@activity.defn | ||||||
async def find_bad_nodes(input: FindBadNodesInput) -> List[str]: | ||||||
await asyncio.sleep(0.1) | ||||||
bad_nodes = [n for n in input.nodes_to_check if int(n) % 5 == 0] | ||||||
if bad_nodes: | ||||||
print(f"Found bad nodes: {bad_nodes}") | ||||||
else: | ||||||
print("No new bad nodes found.") | ||||||
return bad_nodes |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
import argparse | ||
import asyncio | ||
import logging | ||
import uuid | ||
from typing import Optional | ||
|
||
from temporalio import client, common | ||
from temporalio.client import Client, WorkflowHandle | ||
|
||
from updates_and_signals.atomic_message_handlers.workflow import ( | ||
ClusterManagerInput, | ||
ClusterManagerWorkflow, | ||
) | ||
|
||
|
||
async def do_cluster_lifecycle(wf: WorkflowHandle, delay_seconds: Optional[int] = None): | ||
allocation_updates = [] | ||
for i in range(6): | ||
allocation_updates.append( | ||
wf.execute_update( | ||
ClusterManagerWorkflow.allocate_n_nodes_to_job, args=[f"task-{i}", 2] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we want to discourage multiple arguments to things (workflows, activities, signals, queries, updates, etc) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, I missed the updates, sorry. |
||
) | ||
) | ||
await asyncio.gather(*allocation_updates) | ||
|
||
if delay_seconds: | ||
await asyncio.sleep(delay_seconds) | ||
|
||
deletion_updates = [] | ||
for i in range(6): | ||
deletion_updates.append( | ||
wf.execute_update(ClusterManagerWorkflow.delete_job, f"task-{i}") | ||
) | ||
await asyncio.gather(*deletion_updates) | ||
|
||
await wf.signal(ClusterManagerWorkflow.shutdown_cluster) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Arguably shutdown could be an update that returns what the workflow returns instead of making it a two-step process (but this is fine too) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cool idea, and would show off the power of update. Ran out of time this A.M, though. |
||
|
||
|
||
async def main(should_test_continue_as_new: bool): | ||
# Connect to Temporal | ||
client = await Client.connect("localhost:7233") | ||
|
||
cluster_manager_handle = await client.start_workflow( | ||
ClusterManagerWorkflow.run, | ||
ClusterManagerInput(test_continue_as_new=should_test_continue_as_new), | ||
id=f"ClusterManagerWorkflow-{uuid.uuid4()}", | ||
task_queue="atomic-message-handlers-task-queue", | ||
id_reuse_policy=common.WorkflowIDReusePolicy.TERMINATE_IF_RUNNING, | ||
start_signal="start_cluster", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. While I understand this is demonstrating handlers, arguably for users there is not much value of combining these two options together. If you know you always want to do something at the start of the workflow you could call it at the start of the workflow (e.g. when there is no state). No problem with it being here though, may just be a bit confusing. |
||
) | ||
delay_seconds = 10 if should_test_continue_as_new else 1 | ||
await do_cluster_lifecycle(cluster_manager_handle, delay_seconds=delay_seconds) | ||
result = await cluster_manager_handle.result() | ||
print( | ||
f"Cluster shut down successfully. It peaked at {result.max_assigned_nodes} assigned nodes ." | ||
f" It had {result.num_assigned_nodes} nodes assigned at the end." | ||
) | ||
|
||
|
||
if __name__ == "__main__": | ||
logging.basicConfig(level=logging.INFO) | ||
parser = argparse.ArgumentParser(description="Atomic message handlers") | ||
parser.add_argument( | ||
"--test-continue-as-new", | ||
help="Make the ClusterManagerWorkflow continue as new before shutting down", | ||
action="store_true", | ||
default=False, | ||
) | ||
args = parser.parse_args() | ||
asyncio.run(main(args.test_continue_as_new)) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
import asyncio | ||
import logging | ||
|
||
from temporalio import activity, common, workflow | ||
from temporalio.client import Client, WorkflowHandle | ||
from temporalio.worker import Worker | ||
|
||
from updates_and_signals.atomic_message_handlers.workflow import ( | ||
ClusterManagerWorkflow, | ||
allocate_nodes_to_job, | ||
deallocate_nodes_for_job, | ||
find_bad_nodes, | ||
) | ||
|
||
interrupt_event = asyncio.Event() | ||
|
||
|
||
async def main(): | ||
# Connect client | ||
client = await Client.connect("localhost:7233") | ||
|
||
async with Worker( | ||
client, | ||
task_queue="atomic-message-handlers-task-queue", | ||
workflows=[ClusterManagerWorkflow], | ||
activities=[allocate_nodes_to_job, deallocate_nodes_for_job, find_bad_nodes], | ||
): | ||
# Wait until interrupted | ||
logging.info("ClusterManagerWorkflow worker started, ctrl+c to exit") | ||
await interrupt_event.wait() | ||
logging.info("Shutting down") | ||
|
||
|
||
if __name__ == "__main__": | ||
logging.basicConfig(level=logging.INFO) | ||
loop = asyncio.new_event_loop() | ||
try: | ||
loop.run_until_complete(main()) | ||
except KeyboardInterrupt: | ||
interrupt_event.set() | ||
loop.run_until_complete(loop.shutdown_asyncgens()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can just be at a top-level directory of
atomic_message_handlers
, no need to nest an extra directory deepThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I wanted people to see updates and signals for discoverability, and we're planning at least one more updates sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't usually grouped by those top-level features before but more by what the sample does. So we don't have
interceptors/context_propagation
andinterceptors/sentry
, just two top-level separate samples that use the same Temporal features. We just need to determine whether we want this type of grouping now and maybe apply it generally. I know our other samples repositories have also tried to avoid nesting most samples.