Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API key option to Nexus sample #690

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Add API key option to Nexus sample #690

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be131f8
Add API key option to Nexus sample
Quinn-With-Two-Ns Oct 21, 2024
2496a7e
run spotless
Quinn-With-Two-Ns Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 35 additions & 4 deletions core/src/main/java/io/temporal/samples/nexus/options/ClientOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@

package io.temporal.samples.nexus.options;

import io.grpc.Metadata;
import io.grpc.netty.shaded.io.grpc.netty.GrpcSslContexts;
import io.grpc.netty.shaded.io.netty.handler.ssl.SslContextBuilder;
import io.grpc.netty.shaded.io.netty.handler.ssl.util.InsecureTrustManagerFactory;
import io.grpc.stub.MetadataUtils;
import io.temporal.client.WorkflowClient;
import io.temporal.client.WorkflowClientOptions;
import io.temporal.serviceclient.WorkflowServiceStubs;
Expand All @@ -47,14 +49,23 @@ public static WorkflowClient getWorkflowClient(String[] args) {
serverRootCaOption.setRequired(false);
options.addOption(serverRootCaOption);

Option clientCertOption = new Option("client-cert", true, "Optional path to client cert");
Option clientCertOption =
new Option(
"client-cert", true, "Optional path to client cert, mutually exclusive with API key");
clientCertOption.setRequired(false);
options.addOption(clientCertOption);

Option clientKeyOption = new Option("client-key", true, "Optional path to client key");
Option clientKeyOption =
new Option(
"client-key", true, "Optional path to client key, mutually exclusive with API key");
clientKeyOption.setRequired(false);
options.addOption(clientKeyOption);

Option apiKeyOption =
new Option("api-key", true, "Optional API key, mutually exclusive with cert/key");
apiKeyOption.setRequired(false);
options.addOption(apiKeyOption);

Option serverNameOption =
new Option(
"server-name", true, "Server name to use for verifying the server's certificate");
Expand Down Expand Up @@ -89,9 +100,15 @@ public static WorkflowClient getWorkflowClient(String[] args) {
String clientKey = cmd.getOptionValue("client-key", "");
String serverName = cmd.getOptionValue("server-name", "");
boolean insecureSkipVerify = cmd.hasOption("insecure-skip-verify");
String apiKey = cmd.getOptionValue("api-key", "");

// API key and client cert/key are mutually exclusive
if (!apiKey.isEmpty() && (!clientCert.isEmpty() || !clientKey.isEmpty())) {
throw new IllegalArgumentException("API key and client cert/key are mutually exclusive");
}
WorkflowServiceStubsOptions.Builder serviceStubOptionsBuilder =
WorkflowServiceStubsOptions.newBuilder().setTarget(targetHost);
// Configure TLS if client cert and key are provided
if (!clientCert.isEmpty() || !clientKey.isEmpty()) {
if (clientCert.isEmpty() || clientKey.isEmpty()) {
throw new IllegalArgumentException("Both client-cert and client-key must be provided");
Expand All @@ -112,10 +129,24 @@ public static WorkflowClient getWorkflowClient(String[] args) {
} catch (FileNotFoundException e) {
throw new RuntimeException(e);
}
if (serverName != null && !serverName.isEmpty()) {
serviceStubOptionsBuilder.setChannelInitializer(c -> c.overrideAuthority(serverName));
}
}
if (serverName != null && !serverName.isEmpty()) {
serviceStubOptionsBuilder.setChannelInitializer(c -> c.overrideAuthority(serverName));
// Configure API key if provided
if (!apiKey.isEmpty()) {
serviceStubOptionsBuilder.setEnableHttps(true);
serviceStubOptionsBuilder.addApiKey(() -> apiKey);
Metadata.Key<String> TEMPORAL_NAMESPACE_HEADER_KEY =
Metadata.Key.of("temporal-namespace", Metadata.ASCII_STRING_MARSHALLER);
Metadata metadata = new Metadata();
metadata.put(TEMPORAL_NAMESPACE_HEADER_KEY, namespace);
serviceStubOptionsBuilder.setChannelInitializer(
(channel) -> {
channel.intercept(MetadataUtils.newAttachHeadersInterceptor(metadata));
});
}

WorkflowServiceStubs service =
WorkflowServiceStubs.newServiceStubs(serviceStubOptionsBuilder.build());
return WorkflowClient.newInstance(
Expand Down
Loading