Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EarlyReturn sample (Update-With-Start) #689

Merged
merged 15 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
/*
* Copyright (c) 2020 Temporal Technologies, Inc. All Rights Reserved
*
* Copyright 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Modifications copyright (C) 2017 Uber Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"). You may not
* use this file except in compliance with the License. A copy of the License is
* located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package io.temporal.samples.earlyreturn;

import io.temporal.client.*;
import io.temporal.serviceclient.WorkflowServiceStubs;

public class EarlyReturnClient {
private static final String TASK_QUEUE = "EarlyReturnTaskQueue";
private static final String WORKFLOW_ID_PREFIX = "early-return-workflow-";

public static void main(String[] args) {
WorkflowClient client = setupWorkflowClient();
runWorkflowWithUpdateWithStart(client);
}

// Setup the WorkflowClient
public static WorkflowClient setupWorkflowClient() {
WorkflowServiceStubs service = WorkflowServiceStubs.newLocalServiceStubs();
return WorkflowClient.newInstance(service);
}

// Run workflow using 'updateWithStart'
private static void runWorkflowWithUpdateWithStart(WorkflowClient client) {
Transaction tx =
new Transaction(
"", "Bob", "Alice",
1000); // Change this amount to a negative number to have initTransaction fail

WorkflowOptions options = buildWorkflowOptions();
TransactionWorkflow workflow = client.newWorkflowStub(TransactionWorkflow.class, options);

System.out.println("Starting workflow with UpdateWithStart");

UpdateWithStartWorkflowOperation<TxResult> updateOp =
UpdateWithStartWorkflowOperation.newBuilder(workflow::returnInitResult)
.setWaitForStage(WorkflowUpdateStage.COMPLETED) // Wait for update to complete
.build();

TxResult updateResult = null;
try {
WorkflowUpdateHandle<TxResult> updateHandle =
WorkflowClient.updateWithStart(workflow::processTransaction, tx, updateOp);

updateResult = updateHandle.getResultAsync().get();

System.out.println(
"Workflow initialized with result: "
+ updateResult.getStatus()
+ " (transactionId: "
+ updateResult.getTransactionId()
+ ")");

TxResult result = WorkflowStub.fromTyped(workflow).getResult(TxResult.class);
System.out.println(
"Workflow completed with result: "
+ result.getStatus()
+ " (transactionId: "
+ result.getTransactionId()
+ ")");
} catch (Exception e) {
System.err.println("Transaction initialization failed: " + e.getMessage());
}
}

// Build WorkflowOptions with task queue and unique ID
private static WorkflowOptions buildWorkflowOptions() {
return WorkflowOptions.newBuilder()
.setTaskQueue(TASK_QUEUE)
.setWorkflowId(WORKFLOW_ID_PREFIX + System.currentTimeMillis())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Go example, I'm generated the transaction ID on the client and use it in the Workflow ID. That way, the user would receive an error when they start a workflow for the same transaction again. I don't think it's strictly necessary to mimic that here, but I thought I'd mention it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. I intentionally changed it so the early-return would contain meaningful data usable for the rest of the transaction (an early-return / initialization step that returns null isn't very illustrative of real-world value imo)

I plan on following Quinn's suggestion here of still having the ID minted as part of an activity, but doing it in a separate one as part of the initialization step #689 (comment) -- Let me know if there's anything you'd do differently

.build();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
/*
* Copyright (c) 2020 Temporal Technologies, Inc. All Rights Reserved
*
* Copyright 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Modifications copyright (C) 2017 Uber Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"). You may not
* use this file except in compliance with the License. A copy of the License is
* located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package io.temporal.samples.earlyreturn;

import io.temporal.client.WorkflowClient;
import io.temporal.worker.Worker;
import io.temporal.worker.WorkerFactory;

public class EarlyReturnWorker {
private static final String TASK_QUEUE = "EarlyReturnTaskQueue";

public static void main(String[] args) {
WorkflowClient client = EarlyReturnClient.setupWorkflowClient();
startWorker(client);
}

private static void startWorker(WorkflowClient client) {
WorkerFactory factory = WorkerFactory.newInstance(client);
Worker worker = factory.newWorker(TASK_QUEUE);

worker.registerWorkflowImplementationTypes(TransactionWorkflowImpl.class);
worker.registerActivitiesImplementations(new TransactionActivitiesImpl());

factory.start();
System.out.println("Worker started");
}
}
24 changes: 24 additions & 0 deletions core/src/main/java/io/temporal/samples/earlyreturn/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
### Early-Return Sample

This sample demonstrates an early-return from a workflow.

By utilizing Update-with-Start, a client can start a new workflow and synchronously receive
a response mid-workflow, while the workflow continues to run to completion.

To run the sample, start the worker:
```bash
./gradlew -q execute -PmainClass=io.temporal.samples.earlyreturn.EarlyReturnWorker
```

Then, start the client:

```bash
./gradlew -q execute -PmainClass=io.temporal.samples.earlyreturn.EarlyReturnClient
```

* The client will start a workflow using Update-With-Start.
* Update-With-Start will trigger an initialization step.
* If the initialization step succeeds (default), intialization will return to the client with a transaction ID and the workflow will continue. The workflow will then complete and return the final result.
* If the intitialization step fails (amount <= 0), the workflow will return to the client with an error message and the workflow will run an activity to cancel the transaction.

To trigger a failed initialization, set the amount to <= 0 in the `EarlyReturnClient` class's `runWorkflowWithUpdateWithStart` method and re-run the client.
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
/*
* Copyright (c) 2020 Temporal Technologies, Inc. All Rights Reserved
*
* Copyright 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Modifications copyright (C) 2017 Uber Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"). You may not
* use this file except in compliance with the License. A copy of the License is
* located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package io.temporal.samples.earlyreturn;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;

public class Transaction {
private String id; // Mutable field
private String sourceAccount;
private String targetAccount;
private int amount;

// No-arg constructor for serialization frameworks
public Transaction() {}

@JsonCreator(mode = JsonCreator.Mode.PROPERTIES)
public Transaction(
@JsonProperty("id") String id,
@JsonProperty("sourceAccount") String sourceAccount,
@JsonProperty("targetAccount") String targetAccount,
@JsonProperty("amount") int amount) {
this.id = id;
this.sourceAccount = sourceAccount;
this.targetAccount = targetAccount;
this.amount = amount;
}

// Getters and Setters for each field
@JsonProperty("id")
public String getId() {
return id;
}

public void setId(String id) {
this.id = id;
}

@JsonProperty("sourceAccount")
public String getSourceAccount() {
return sourceAccount;
}

public void setSourceAccount(String sourceAccount) {
this.sourceAccount = sourceAccount;
}

@JsonProperty("targetAccount")
public String getTargetAccount() {
return targetAccount;
}

public void setTargetAccount(String targetAccount) {
this.targetAccount = targetAccount;
}

@JsonProperty("amount")
public int getAmount() {
return amount;
}

public void setAmount(int amount) {
this.amount = amount;
}

@Override
public String toString() {
return String.format(
"Transaction{id='%s', sourceAccount='%s', targetAccount='%s', amount=%d}",
id, sourceAccount, targetAccount, amount);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
/*
* Copyright (c) 2020 Temporal Technologies, Inc. All Rights Reserved
*
* Copyright 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Modifications copyright (C) 2017 Uber Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"). You may not
* use this file except in compliance with the License. A copy of the License is
* located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package io.temporal.samples.earlyreturn;

import io.temporal.activity.ActivityInterface;
import io.temporal.activity.ActivityMethod;

@ActivityInterface
public interface TransactionActivities {
@ActivityMethod
Transaction initTransaction(Transaction tx);

@ActivityMethod
void cancelTransaction(Transaction tx);

@ActivityMethod
void completeTransaction(Transaction tx);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
/*
* Copyright (c) 2020 Temporal Technologies, Inc. All Rights Reserved
*
* Copyright 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Modifications copyright (C) 2017 Uber Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"). You may not
* use this file except in compliance with the License. A copy of the License is
* located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package io.temporal.samples.earlyreturn;

import io.temporal.failure.ApplicationFailure;

public class TransactionActivitiesImpl implements TransactionActivities {

@Override
public Transaction initTransaction(Transaction tx) {
System.out.println("Initializing transaction");
sleep(500);
if (tx.getAmount() <= 0) {
System.out.println("Invalid amount: " + tx.getAmount());
throw ApplicationFailure.newNonRetryableFailure(
"Non-retryable Activity Failure: Invalid Amount", "InvalidAmount");
}
tx.setId("TXID" + String.format("%010d", (long) (Math.random() * 1_000_000_0000L)));
sleep(500);
steveandroulakis marked this conversation as resolved.
Show resolved Hide resolved
return tx;
}

@Override
public void cancelTransaction(Transaction tx) {
System.out.println("Cancelling transaction");
sleep(2000);
System.out.println("Transaction cancelled");
}

@Override
public void completeTransaction(Transaction tx) {
System.out.println(
"Sending $"
+ tx.getAmount()
+ " from "
+ tx.getSourceAccount()
+ " to "
+ tx.getTargetAccount());
sleep(2000);
System.out.println("Transaction completed successfully");
}

private void sleep(long millis) {
try {
Thread.sleep(millis);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/*
* Copyright (c) 2020 Temporal Technologies, Inc. All Rights Reserved
*
* Copyright 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Modifications copyright (C) 2017 Uber Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"). You may not
* use this file except in compliance with the License. A copy of the License is
* located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed on
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/

package io.temporal.samples.earlyreturn;

import io.temporal.workflow.UpdateMethod;
import io.temporal.workflow.WorkflowInterface;
import io.temporal.workflow.WorkflowMethod;

@WorkflowInterface
public interface TransactionWorkflow {
@WorkflowMethod
TxResult processTransaction(Transaction tx);

@UpdateMethod(name = "early-return")
TxResult returnInitResult();
}
Loading
Loading