Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
📖 Docs PR preview links
|
drewhoskins-temporal
left a comment
drewhoskins-temporal
left a comment
There was a problem hiding this comment.
nit: Can you also note that you removed the advanced topics section in the PR desc?
It's neat that snipsync uses inline content, which should make it easier for LLMs to understand.
| plugin = SimplePlugin( | ||
| data_converter = add_converter | ||
| plugin = Temporalio::SimplePlugin.new( | ||
| name: 'PluginName', |
There was a problem hiding this comment.
Orthogonal but perhaps convenient to tackle here.
I have realized that we need scope names to disambiguate these plugins, and I think customers would like that too for their observability. i.e. "AgentPlugin" and "AiSDKPlugin" are so generic.
WDYT about recommending my_scope.MyPlugin for all of these? We can suggest package/module/gh repo name as scopes.
However, I don't feel a strong need to ask for cross-language naming consistency.
| </SdkTabs.Ruby> | ||
| </SdkTabs> | ||
|
|
||
| ### Special considerations for different languages |
There was a problem hiding this comment.
isn't there bundles for TS?
3 participants
What does this PR do?
Notes to reviewers
┆Attachments: EDU-5958 Add all languages to plugin guide