Migrate Guides with Cloud metrics from PromQL v0 to OpenMetrics v1#4246
Open
dustin-temporal wants to merge 3 commits intomainfrom
Open
Migrate Guides with Cloud metrics from PromQL v0 to OpenMetrics v1#4246dustin-temporal wants to merge 3 commits intomainfrom
dustin-temporal wants to merge 3 commits intomainfrom
Conversation
Replace temporal_cloud_v0_* metrics with temporal_cloud_v1_* equivalents across worker-health, service-health, and HA monitoring pages. Key changes: - worker-health: Replace v0 poll metrics with v1, remove rate() wrapping from queries (v1 metrics are pre-computed rates), add approximate_backlog_count - service-health: Fix metric display names (drop frontend_ prefix), replace SDK activity_execution_failed with Cloud v1 activity_fail_count, fix query to not use increase() on pre-computed rates - ha-monitoring: Replace v0 histogram queries with v1 pre-computed percentiles, add p95 query, update reference links Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
dustin-temporal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
temporal_cloud_v0_poll_success_count,_sync_count,_timeout_countwith v1 equivalents. Removerate()wrapping from all Cloud metric queries (v1 metrics are pre-computed rates). Addtemporal_cloud_v1_approximate_backlog_countguidance (was a TODO in the source). Update reference links to OpenMetrics metrics reference.frontend_service_error_count->service_error_countto match actual v1 names). Replace SDKtemporal_activity_execution_failedwith Cloudtemporal_cloud_v1_activity_fail_count. Removeincrease()from query on pre-computed rate metrics. Replace vaguetotal_activitiesformula with concrete v1 metrics.histogram_quantile(0.99, sum(rate(temporal_cloud_v0_replication_lag_bucket...)))) with simple v1 percentile references (temporal_cloud_v1_replication_lag_p99). Add p95 query. Replacetemporal_cloud_v0_total_action_countwith v1. Update reference links.SDK metrics (schedule-to-start latency, task slots, sticky cache) are intentionally left as-is on worker-health since they have no Cloud v1 equivalent.
Test plan
rate()/increase()on pre-computed rates)approximate_backlog_countguidance is accurate for current OpenMetrics Public Preview🤖 Generated with Claude Code
┆Attachments: EDU-5957 Migrate Cloud metrics from PromQL v0 to OpenMetrics v1