EDU-3510: Python: Added paragraph that warns about pytest.fixture(scope="session") with test server #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created SDK-2941 to review |
fairlydurable
changed the title
cretz
reviewed
Nov 25, 2024
|
|
||
|
|
||
| # This might break because it will reuse the workflow environment | ||
| pytest.fixture(scope="session") |
There was a problem hiding this comment.
Suggested change
| pytest.fixture(scope="session") | |
| @pytest.fixture(scope="session") |
If you do keep this, need @
Co-authored-by: Chad Retz <[email protected]>
Co-authored-by: Chad Retz <[email protected]>
cretz
reviewed
Dec 2, 2024
| # environment will be created for each test. | ||
| @pytest.fixture | ||
| def workflow_environment(): | ||
| return WorkflowEnvironment.start_time_skipping() |
There was a problem hiding this comment.
I am not sure this works without @pytest_asyncio.fixture and async and await. Have you tested this code? And for many, they may prefer a "session" scoped start_local instead of time skipping even though this only demonstrates time skipping.
There was a problem hiding this comment.
That's a good point, was using the auto-mode in my tests https://pytest-asyncio.readthedocs.io/en/latest/reference/configuration.html but I agree that being explicit works better
Co-authored-by: Chad Retz <[email protected]>
|
@edmondop Thanks for all your work on this. Please ping me and let me know when it is ready to move forward. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses #3111 . When running tests in a project I noticed:
This additional paragraph should warn developers familiar with pytest.fixtures not to use the scope session for caching the workflow environment