Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: use pg_config path from environment variable instead of hardcoded binary #336

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

palash25
Copy link
Contributor

@palash25 palash25 commented Oct 31, 2024

The use of pg_config binary was inconsistent in the Makefile, I realized this while building pg_vectorize locally, it installs pgmq in its make setup step and supplies the pg_config path as an env var which was getting ignored here due to the use of hardcoded path, which would fail on machines that don't have postgres installed and pg_vectorize setup would fail with this error:

/bin/sh: 1: pg_config: not found
/bin/sh: 1: test: -ge: unexpected operator

@v0idpwn v0idpwn merged commit 1304a15 into tembo-io:main Oct 31, 2024
15 of 19 checks passed
@v0idpwn
Copy link
Collaborator

v0idpwn commented Oct 31, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants