Makefile: use pg_config path from environment variable instead of hardcoded binary #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
pg_config
binary was inconsistent in the Makefile, I realized this while buildingpg_vectorize
locally, it installspgmq
in itsmake setup
step and supplies the pg_config path as an env var which was getting ignored here due to the use of hardcoded path, which would fail on machines that don't have postgres installed and pg_vectorize setup would fail with this error: