fix(pager): select value in adaptive pager has wrong vertical alignment in Safari #5243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM :) However I would suggest to cut short the commit message. Also, the "pager" should start with small letter |
dimodi
changed the title
dimodi
force-pushed
the
pager-select-safari
branch
from
8db7334
to
e1025a1
Compare
|
OK, I fixed the letter casing and shortened the commit message a bit. |
|
@dimodi , in the description of the issue you can add "fixes: {link to the targeted issue}" - in this way once the PR is closed, the issue will be automatically closed as well. |
inikolova
approved these changes
Nov 27, 2024
dimodi
force-pushed
the
pager-select-safari
branch
from
e1025a1
to
c865f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5242
Another option may be to avoid flexbox for the
selectelement, but this may need more lines of code.