-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Html specs corrections grid #5233
Open
TeyaVes
wants to merge
15
commits into
develop
Choose a base branch
from
html-specs-corrections-grid
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeyaVes
force-pushed
the
html-specs-corrections-grid
branch
5 times, most recently
from
November 19, 2024 07:55
7d6c249
to
d722dad
Compare
The class does not hold any styles and seems to be obsolete
The class seems to be obsolete
The class does not hold any styles and seems to be obsolete
The container should be rendered only when virtualization is turned on
The k-grid-draggable-header class should be added to k-grid-header. It adds touch-action: none style to the header and thus, no k-touch-action-none utility class is needed for the th elements.
TeyaVes
force-pushed
the
html-specs-corrections-grid
branch
from
November 19, 2024 09:44
dbb8109
to
b37636d
Compare
epetrow
reviewed
Nov 20, 2024
TeyaVes
force-pushed
the
html-specs-corrections-grid
branch
from
November 20, 2024 14:37
4144921
to
2e8c730
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targets: https://github.com/telerik/kendo-themes-private/issues/246
This PR targets the following items from the related issue:
Grid, TreeList
Items
The k-grid-draggable-header class should be added to k-grid-header. It adds touch-action: none style to the header and thus, no k-touch-action-none utility class is needed for the th elements.
it does not hold any styles and it seems to be obsolete
Should be rendered only when virtualization is turned on. It is used to set the height for the scrollbar
We won't be adding any state classes for the dropdownlist in the template of the Grid pager- the purpose of this template is to check the markup of the Grid, not the DropdownList