Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html specs corrections grid #5233

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Conversation

TeyaVes
Copy link
Contributor

@TeyaVes TeyaVes commented Nov 15, 2024

targets: https://github.com/telerik/kendo-themes-private/issues/246

This PR targets the following items from the related issue:

Grid, TreeList
Items

  • k-touch-action-none - add to groupable scenario and when dragging headers
    The k-grid-draggable-header class should be added to k-grid-header. It adds touch-action: none style to the header and thus, no k-touch-action-none utility class is needed for the th elements.
  • k-grid-draggable-header - add to groupable/reorderable scenario
  • k-grouping-dropclue - remove from template tests
  • k-chip-label - add class to grid chips
  • k-table-alt-row - check for consistent usage (reported for grid-with-grouping)
  • k-virtual-content - (added when grid is scrollable) check if it can be removed
    it does not hold any styles and it seems to be obsolete
  • k-height-container - (should not be used if grid is not scrollable) check if it can be removed in favor of a more modern CSS solution -
    Should be rendered only when virtualization is turned on. It is used to set the height for the scrollbar
  • k-touch-action-auto - check usage, and remove from templates/tests where needed.
  • k-selection-aggregates - should move outside the aria-root
  • k-dropdown-list - (in grid pager) should be selected
    We won't be adding any state classes for the dropdownlist in the template of the Grid pager- the purpose of this template is to check the markup of the Grid, not the DropdownList
  • k-treelist-group - check if it can be removed
  • undefined - remove undefined class from templates - previously fixed
  • k-editable - check if it can be removed
  • check if k-drag-cell class can be removed from treelist header's empty cell
  • GridHeaderCell component should render k-filterable when the menu is 'column'

@TeyaVes TeyaVes self-assigned this Nov 15, 2024
@TeyaVes TeyaVes force-pushed the html-specs-corrections-grid branch 5 times, most recently from 7d6c249 to d722dad Compare November 19, 2024 07:55
@TeyaVes TeyaVes marked this pull request as ready for review November 20, 2024 07:37
@TeyaVes TeyaVes requested a review from a team as a code owner November 20, 2024 07:37
@TeyaVes TeyaVes requested review from a team and removed request for a team November 20, 2024 07:37
@TeyaVes TeyaVes added this to the 2024 Q4 (Nov) milestone Nov 20, 2024
@Juveniel Juveniel modified the milestones: 2024 Q4 (Nov), 2025 Q1 (Feb) Nov 20, 2024
@zhpenkov zhpenkov self-requested a review November 20, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants