Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
5d08895
Prepare new class PhoneNumberValidator - currently just reusing Phone…
Anrufliste May 1, 2024
1a9fab7
Update copyright year of initial setting
Anrufliste May 1, 2024
a0553a8
Initial testing 5 separated cases
Anrufliste May 4, 2024
0bb41fc
Create Area Code Extractor (NDC) for Germany.
Anrufliste May 20, 2024
6d867b6
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
9710fea
Starting Validator.
Anrufliste May 20, 2024
3801358
Include Mobile NDCs into generator script for GermanAreaCodeExtractor…
Anrufliste May 21, 2024
1cd08ae
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 22, 2024
e6df209
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
6fcdad4
Introducing INVALID_PREFIX_OF_SUBSCRIBER_NUMBER and reorganize expect…
Anrufliste Jun 3, 2024
cf61342
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
e6c91af
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
22c7bc1
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
5a9af3c
Adding todo in Validation Code to support not yet supported PhoneNumb…
Anrufliste Jun 4, 2024
8eae419
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
6e8cd8a
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
52de125
Issue for +49115 resubmitted
Anrufliste Jun 21, 2024
1479dbe
Adding Validation test for 118(y)xx call assitant. Adapting Validatio…
Anrufliste Jun 23, 2024
c6dc99d
Initial testing 5 separated cases
Anrufliste May 4, 2024
51e79d9
Initial testing 5 separated cases
Anrufliste May 4, 2024
e53dcab
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
c31f13c
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
63e0dfe
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
a2819b3
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
49bf236
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
5794663
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
88f8231
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
ff905d1
Initial testing 5 separated cases
Anrufliste May 4, 2024
2181508
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
e792220
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
b6b0a23
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
554a85e
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
2c39a41
Initial testing 5 separated cases
Anrufliste May 4, 2024
8da9ece
Initial testing 5 separated cases
Anrufliste May 4, 2024
2fdc63a
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
8b1aa50
Starting Validator.
Anrufliste May 20, 2024
9c51290
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
a152660
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
5a67613
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
0d2864f
Merging 1.3.1 with Validator C
Anrufliste Oct 5, 2024
585cfe9
comment adaption
Anrufliste Oct 23, 2024
52a649c
Prepare new class PhoneNumberValidator - currently just reusing Phone…
Anrufliste May 1, 2024
2d71821
Update copyright year of initial setting
Anrufliste May 1, 2024
4ec2169
Initial testing 5 separated cases
Anrufliste May 4, 2024
7a11b15
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
fe9b656
Starting Validator.
Anrufliste May 20, 2024
4aa783b
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
1a75b31
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
9b9de65
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
6129696
Adding Validation test for 118(y)xx call assitant. Adapting Validatio…
Anrufliste Jun 23, 2024
4e8a5b1
Initial testing 5 separated cases
Anrufliste May 4, 2024
6375819
Initial testing 5 separated cases
Anrufliste May 4, 2024
228f334
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
c6a194c
Short Code 110 and 112 are not valid start for fixed line numbers (ND…
Anrufliste May 30, 2024
6f6fe86
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
dcab064
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
0522929
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 4, 2024
70c6405
Update Comments on 110 & 112 & 115 number checks to explain reason an…
Anrufliste Jun 8, 2024
fbf1292
Adding Validation test for 116xxx social service short codes. Adaptin…
Anrufliste Jun 9, 2024
89f0553
Initial testing 5 separated cases
Anrufliste May 4, 2024
0912031
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
fb99b4c
Adapted 115 Goverment shor code, which is different to 110 & 112 shor…
Anrufliste Jun 3, 2024
fb404f4
Optimize Validation Code by moving duplicate code structure into chec…
Anrufliste Jun 3, 2024
0583805
Initial testing 5 separated cases
Anrufliste May 4, 2024
f4f5448
Initial testing 5 separated cases
Anrufliste May 4, 2024
72c0737
Extend Number Plan to provide multi dimensional short code information.
Anrufliste May 20, 2024
c7dc1d2
Starting Validator.
Anrufliste May 20, 2024
2773dbe
Merging 1.3.1 with Validator C
Anrufliste Oct 5, 2024
e08d73e
Adapt testing expectation to corrected PhoneLib behaviour
Anrufliste Nov 8, 2024
e0af894
Adding 199 as NDC for National Operator Only.
Anrufliste Nov 8, 2024
7185b0e
Adding 700 as NDC for personal numbers.
Anrufliste Nov 9, 2024
c2bc969
List all NDC testcases which needs to be added at PhoneNumberValidato…
Anrufliste Nov 9, 2024
fc8ce91
Adding ambulance transport 19222 short code
Anrufliste Nov 15, 2024
eb6207b
Inluded 137 for validation and introduced new mechanism to detect res…
Anrufliste Nov 18, 2024
08b4d5a
removed abdon approach for reserved number ranges
Anrufliste Nov 18, 2024
561010f
Extend NDC extraction with phonelib RFC3966 formation for not improve…
Anrufliste Mar 3, 2025
9cc9b3e
Added mobile 15x including infixes for voicemail for validation
Anrufliste Mar 7, 2025
ab9f911
Entered a bug report for 19222 special ruling to google and linked it…
Anrufliste Mar 18, 2025
c999eb9
Added mobile 16x including infixes for voicemail and mobile reserved …
Anrufliste Mar 29, 2025
5b369e4
Added 16(8/9) range of 'Funkruf' for validation
Anrufliste Mar 29, 2025
38bc718
minimal CleanUp
Anrufliste Apr 12, 2025
593546b
Added mobile 17x including infixes for voicemail
Anrufliste Apr 12, 2025
575bf34
Added service range 180 including reserve
Anrufliste Apr 12, 2025
9a19d4c
Update to 2.1.1-SNAPSHOT
Anrufliste Jul 18, 2025
ccf310b
Add new assigned mobile NDC
Anrufliste Jul 31, 2025
722ae7e
Moved special ruling before general NDC extraction, so that reserved …
Anrufliste Jul 31, 2025
7180b44
Added clarification to INVALID_NATIONAL_DESTINATION_CODE and implemen…
Anrufliste Jul 31, 2025
5247b61
Update Mobile NDC extractor generator and generate new GermanAreaCode…
Anrufliste Aug 8, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion REPORTED_ISSUES.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ However, it’s possible that this has caused confusion about which parts of the
This issue addresses special short codes used for phone number directory assistant services.
This issue has been resolved.

Google [fixed](https://github.com/google/libphonenumber/pull/2601/files#diff-1887949025d4940ce0f39cc4ba17666b5d93be2f143867b77c26bcddb36ac696R3400) ít with [8.12.21](https://github.com/google/libphonenumber/pull/2601) on 15.05.2024.

### 2021-03-25 - [Germany (DE, +49): 116xxx Short Number valid vs. assigned](https://issuetracker.google.com/issues/183669955)

This issue pertains to the EU-wide special social number short code definition. Although the regulation clearly defines a range, Google's LibPhoneNumber is not validating against that range, but against a list of currently assigned/operated numbers. At least for the German number space, as mentioned in the initial issue discussion (see first one above), the library is only partly or even completely checking the whole range in other EU number spaces.
Expand Down Expand Up @@ -50,6 +52,23 @@ We have provided Ludwighafen in our labeling data.

Google [fixed](https://github.com/google/libphonenumber/pull/3473/files#diff-db8e5b3fb2cb4a7ed9856289ea12d54947bfaa10549e6c1058fec7f3a1359dbbR3260) ít with [8.13.37](https://github.com/google/libphonenumber/pull/3473) on 15.05.2024.

### 2024-05-22 - [Emergency Numbers must not be used with National Destination Code in Germany fixed line](https://issuetracker.google.com/issues/341947688)

BnetzA [described emergency short codes 110 & 112 as numbers without local NDC](https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/np_nummernraum.pdf?__blob=publicationFile&v=1), since NDC is optional in fixed line, no number might start with those three digits (otherwise using such a number without NDC would trigger the emergency call). In mobile networks NDC is mandatory, so a number might start with those three digits, since NDC would be a prefix. Real live examples have been found.

Google acknowledged the issue, but marked it as "**Won't fix (Intended behavior)**" because "*We will definitely think about it but it is not a priority right now. Also we have already mentioned about the complexity and invalid or false positive numbers in our XML file of Germany https://github.com/google/libphonenumber/blob/30db8f67a1c06b3ab052497477be1d9f18312387/resources/PhoneNumberMetadata.xml#L8126*" on 27.05.2024
Google [fixed](https://github.com/google/libphonenumber/pull/3473/files#diff-db8e5b3fb2cb4a7ed9856289ea12d54947bfaa10549e6c1058fec7f3a1359dbbR3260) ít with [8.13.37](https://github.com/google/libphonenumber/pull/3473) on 15.05.2024.

### 2024-06-08 - [Government Service Numbers may be used with National Destination Code in Germany fixed line, but subscriber numbers may not start with it](https://issuetracker.google.com/issues/345753226)

BnetzA [described government short codes 115](https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/115/115_Nummernplan_konsolidiert.pdf?__blob=publicationFile&v=1), no number might start with those three digits (otherwise using such a number would trigger the short code). Furthermore the short code might be called with IDP and Country code (**+49115**) but from outside Germany and not from within - here the used region must have an influence on the evaluation.

Google since 09.07.2024, the Issue is not publicly accessible anymore - we wrote a [post in the Google discussion group](https://groups.google.com/g/libphonenumber-discuss/c/WQv244-PVmI).

### 2024-06-16 - [+49115 German Government short number with IDP+CC is only valid from outside Germany but not within (so IS_POSSIBLE_LOCAL_ONLY is also wrong)](https://issuetracker.google.com/issues/347356467)

Since the previous Issue "disappeared" without notice, we assume, it was structural too similar to the emergencies number issue and the reviewer did not recordnized the differences. So we reported the main difference - again and this time the issue is at least accepted. But the reviewer comment seems only to focus on the short number call-ability from outside the country and not that IDP+CC+115 must not be used from inside.

### 2024-09-03 - [German Mobile number length validation for range 17x inconsistently differentiated in 8.13.43](https://issuetracker.google.com/issues/364179199)

Previous to Version 8.13.43 any German number within the range 17x was identified valid for both length 10 & 11. Now the 11 length case (176) is differentiated, that 176 is not validated valid with 10 digits. But 170-175, 177-179 is still validated valid for both length, but should be only valid with length of 10.
Expand All @@ -63,8 +82,16 @@ While normal mobile numbers are now aligend, voicemail numbers length is still p
While Google had corrected mobile 17x range with prior feedback, they introduced an inconsistency with the last DE meta data update, allowing also 10 length number while only 11 are valid.
They do not want to change it, because they user are blocked with historical shorter numbers (but no prove found that those really exists)

### 2025-03-08 - [German special ambulance number for non-emergency calls 19222 not correctly identified without NDC and with addition not marked as invalid](https://issuetracker.google.com/issues/401693552)

19222 is used for ambulance without an emergency. It is the only allowed entry of previous special 19xxx number. This is callable at fixedline with or without NDC. Currently Google is not correctly validating it without NDC and with NDC its validation is ok, but also longer numbers are marked valid, which is wrong.

Google first did not acknowledge the issue by referring to the general number plan and marked it as "**Won't fix (Intended behavior)**" (10th May 2025). On your rebuttal, they keep the mark and responded "*In order to keep the size of the XML files to a reasonable level, it's necessary in some regions (e.g. "DE" or "AT") to simplify number ranges. This results in a relatively small amount of false positive numbers (i.e. numbers that should be reported as invalid, but which are now shown as valid).*"

### 2025-06-15 - [Metadata Update of 9.0.7 for DE mobile 172 range is invalide](https://issuetracker.google.com/issues/425121215)
Similar to previously change of 176, Google change mobile 172 ~~introduced an inconsistency with the last DE meta data update, allowing also 11 length number while only 10 are valid~~.

Google clarified, there is [another document by BnetzA](https://www.bundesnetzagentur.de/DE/Fachthemen/Telekommunikation/Nummerierung/MobileDienste/Nummernplan_MobileDienste.pdf?__blob=publicationFile&v=1) which opens the range and maybe the mobile summary page was not updated.
While 9.0.7 meta data update was inconsistent with 178 & 179 those have been adjusted with 9.0.8
While 9.0.7 meta data update was inconsistent with 178 & 179 those have been adjusted with 9.0.8
While Google had corrected mobile 17x range with prior feedback, they introduced an inconsistency with the last DE meta data update.

Loading
Loading