Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix illegible white on yellow text of stacktrace #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NikolayXHD
Copy link

@NikolayXHD NikolayXHD commented Oct 15, 2022

Higlighted stacktrace background color is inherited from default theme, which is bright yellow,
while default text foreground becomes also bright in dark themes, thus becoming unreadable.

before

image

after

image

For reference, there is analogous PR to default JupyterLab dark theme

@dhirschfeld
Copy link

dhirschfeld commented Aug 6, 2023

It would be great to get this in! This theme is great, but this is a pretty bit pain-point with day-to-day use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants