Handle invalid option in the tmt-reboot script
#3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a minor issues detected by the shell-check.
psss
requested review from
lukaszachy,
happz,
thrix and
janhavlin
as code owners
psss
added
step | execute
siteshwar
reviewed
Nov 12, 2024
| @@ -18,6 +18,7 @@ while getopts "c:t:e" flag; do | |||
| c) command="${OPTARG}";; | |||
| t) timeout="${OPTARG}";; | |||
| e) efi=False;; | |||
| *) exit 1;; | |||
There was a problem hiding this comment.
You may want to put a message there to the user about invalid argument.
There was a problem hiding this comment.
This is already handled by getopt:
tmt-reboot: illegal option -- x
So I guess we don't have to duplicate the error message.
|
@psss Also, you may want to disable checks on the warnings that you do not plan to fix. Thanks! |
We already exclude certain paths in the github workflow: tmt/.github/workflows/shellcheck.yml Lines 29 to 33 in 938d8bc Can we do a similar thing for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a minor issues detected by the shell-check.