-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go to discover tests directory after login #3357
Conversation
Solves issue #803 So the user needs to run |
3f62bd3
to
274bdb5
Compare
274bdb5
to
5480a8c
Compare
Okay, I have here some failures because the test path, that I expect, is
and run it with this tmt command: Fixed by commit: 8f946c9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much experience with tmt try code, but tried it and this /bin/true approach seems to work :)
8f946c9
to
b67e154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this. Looks good. I just think that we do not have to exercise the /bin/true
check when there are no tests. Adjusted in b67e154. Please have a look if the change is ok. It would be also good to add at least a basic test coverage and mention this in release notes as this feature was requested by users and they should learn about this good news :-)
b67e154
to
18e98ea
Compare
18e98ea
to
38e5171
Compare
Pull Request Checklist