-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logfile size upload limit to the reportportal
plugin
#3199
Conversation
10aded9
to
6a5fc18
Compare
b9a19af
to
a81dc30
Compare
Would it be useful to submit at least an abridged version of the log, with the "too long, had to cut" header? With the proposed code, user gets a note and nothing more, while even a shortened log might bring at least some value. |
556a7d5
to
6445517
Compare
ec94f05
to
6ec0722
Compare
reportportal
plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Looks good, only we should also update the schema to add the newly supported option. Also, it might be worth at least a short release note?
4b3b9d8
to
5f1ba96
Compare
@psss @happz @martinhoyer Hi, I did some updates in the script so please review it whether it makes sense. I have decided to introduce separate limit for traceback log as this is the input for RP AutoAnalysis and I believe that it doesn't make sense to match 1MB logs. |
9f220a7
to
e247b5a
Compare
Rebased & moved release note where it belongs. In f617cb3, I tried to switch from @kkaarreell I tried to test it a bit, let me know what do you think. Edit: still testing, it wasn't ready. |
Sounds great. I will try to test it as well later this week. |
Pull Request Checklist