Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Toolbelt Catalog entry for tmt #2532

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Add a Toolbelt Catalog entry for tmt #2532

merged 1 commit into from
Dec 15, 2023

Conversation

psss
Copy link
Collaborator

@psss psss commented Nov 30, 2023

To be used to build the Toolbelt Catalog.
Fix https://issues.redhat.com/browse/QC-66

Pull Request Checklist

  • write the documentation

@psss psss added the documentation Improvements or additions to documentation label Nov 30, 2023
@psss psss added this to the 1.31 milestone Dec 6, 2023
@psss psss force-pushed the toolbelt-entry branch 10 times, most recently from a8637f4 to 05ead93 Compare December 14, 2023 12:10
@psss psss marked this pull request as ready for review December 14, 2023 12:22
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz
Copy link
Collaborator

happz commented Dec 15, 2023

@psss is the file name mandatory? I'm wondering whether it'd make sense to leave the door open to all those other catalogs by making this one less generic, e.g. by calling it toolbelt-catalog.info.

@psss
Copy link
Collaborator Author

psss commented Dec 15, 2023

@psss is the file name mandatory?

Yes, the system does not accept anything else. I was a bit afraid that it will have to be in the root directory, but fortunately it can be in a different directory. But that's it about what we can do here.

Copy link
Collaborator

@happz happz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thou shalt have no other catalogs before me...

Ok, no longer true :)

@psss
Copy link
Collaborator Author

psss commented Dec 15, 2023

Oh! And I'm taking back, what I just said. I would swear I tried it yesterday with a different name and it would not accept anything else, but today it does :-) I'll use toolbelt-catalog.yaml then.

To be used to build the `Toolbelt Catalog`.
Fix https://issues.redhat.com/browse/QC-66
@psss
Copy link
Collaborator Author

psss commented Dec 15, 2023

The sister pull request for fmf is ready for review as well:

@psss
Copy link
Collaborator Author

psss commented Dec 15, 2023

/packit test --identifier full

@psss psss merged commit 91fe542 into main Dec 15, 2023
18 checks passed
@psss psss deleted the toolbelt-entry branch December 15, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants