Add a Toolbelt Catalog entry for tmt
#2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psss
force-pushed
the
toolbelt-entry
branch
10 times, most recently
from
a8637f4
to
05ead93
Compare
psss
requested review from
lukaszachy,
happz,
thrix and
janhavlin
as code owners
|
@psss is the file name mandatory? I'm wondering whether it'd make sense to leave the door open to all those other catalogs by making this one less generic, e.g. by calling it |
Yes, the system does not accept anything else. I was a bit afraid that it will have to be in the root directory, but fortunately it can be in a different directory. But that's it about what we can do here. |
happz
approved these changes
Dec 15, 2023
|
Oh! And I'm taking back, what I just said. I would swear I tried it yesterday with a different name and it would not accept anything else, but today it does :-) I'll use |
To be used to build the `Toolbelt Catalog`. Fix https://issues.redhat.com/browse/QC-66
|
The sister pull request for |
|
/packit test --identifier full |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used to build the
Toolbelt Catalog.Fix https://issues.redhat.com/browse/QC-66
Pull Request Checklist