Default exclusions externalised to json config file

[pnd001]

Hi team,

I had an issue with some of the default exclusions overriding my user defined paths, specifically /data/; I couldn't change this because the default exclusions were hard coded.

I've moved them into the json config file now and it's working the way I expect. Let me know if you need more info.

[LubosRemplik]

@pnd001 looks good, as per #876 I think it would be better to have default /etc/timeshift/exclude.list file

Question, how do you build and replace timeshift at you operation system? I am running majaro, but I guess it is same with e.g. ubuntu.

[zaits07]

Please, merge this PR...

[pnd001]

@pnd001 looks good, as per #876 I think it would be better to have default /etc/timeshift/exclude.list file

Question, how do you build and replace timeshift at you operation system? I am running majaro, but I guess it is same with e.g. ubuntu.

Hi there, sorry I missed this - I've been really busy and haven't been checking my github. Yeah agree an exclude.list file would be better, have you implemented this?

Regarding the build, I'm running Ubuntu 20.04 LTS and it was a bit of a mission to get it working; but I posted my full steps at https://unix.stackexchange.com/questions/587654/cannot-install-timeshift-on-kali/669729#669729.

[RicardoFernandez-UY]

Hi,
Any estimation on when this PR will be merged? It will be a very useful improvement.
Thank you!!

[pnd001]

I can resolve the merge conflicts but don't have merge rights, I haven't heard from @teejee2008

[RicardoFernandez-UY]

I can resolve the merge conflicts but don't have merge rights, I haven't heard from @teejee2008

@pnd001 Thank you very much for your answer!
I'm by no means an expert in GitHub, so my apologies in advance if what I'm saying is conceptually wrong, but what if you post your merge requests to this other project: https://github.com/linuxmint/timeshift that apparently is more active than teejee's, (it says so in a note at teejee's project), and also seem to be the ones maintaining the application in several Linux distribution repositories.
Perhaps someone there with write privileges can merge your improvements, and make them available to the latest release.
I hope this helps.

[teejee2008]

In my opinion this should not be merged. The default exclusion list is critical to ensure that the apps works as intended. Allowing the user to change the default exclude list will cause problems.

[RicardoFernandez-UY]

In my opinion this should not be merged. The default exclusion list is critical to ensure that the apps works as intended. Allowing the user to change the default exclude list will cause problems.

Hi teejee2008,
Thank you very much for your answer!
As you are the creator of the software I believe your words of precaution should be taken seriously.
Perhaps if you could be more specific about the problems you foresee, that could shed light on why not to go on with this, or, what precautions to take and the risks involved.
Thank you!!

[zaits07]

Allowing the user to change the default exclude list will cause problems.

but we have some sort of protection - user need root or sudo to break external default exclusion list.