Preserving percentage gradient decimals and correctly clamp coordinates#815
Merged
nicolaasuni merged 1 commit intotecnickcom:mainfrom Nov 21, 2025
Merged
Preserving percentage gradient decimals and correctly clamp coordinates#815nicolaasuni merged 1 commit intotecnickcom:mainfrom
nicolaasuni merged 1 commit intotecnickcom:mainfrom
Conversation
nicolaasuni
approved these changes
Nov 21, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Percentage based gradient coordinates are rounded to integers, instead of floats, before conversion to a ratio. The subsequent clamping operation is then performed against the original value in $val instead of the result of ratio conversion.
This PR preserves the decimals of the percentage coordinates and correctly clamps against the updated result.
Angled gradient output is therefore much improved for SVG's such as below.