✨ add MySQL 8.4 and MariaDB 11.4 support #122
Conversation
WalkthroughThis update enhances the testing framework and documentation for a project by adding support for multiple Python versions (3.8 to 3.12) in the CI configuration, ensuring broader compatibility and testing coverage. Additionally, the README is updated to reflect support for MariaDB version 11.4 and MySQL version 8.4, improving clarity for users regarding database compatibility. Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI System
participant Python as Python Environment
participant MariaDB as MariaDB
participant MySQL as MySQL
CI->>Python: Trigger tests for Python 3.8 with MariaDB
Python->>MariaDB: Connect to MariaDB 11.4
MariaDB-->>Python: Return connection success
Python-->>CI: Return test results
CI->>Python: Trigger tests for Python 3.8 with MySQL
Python->>MySQL: Connect to MySQL 8.4
MySQL-->>Python: Return connection success
Python-->>CI: Return test results
%% This continues for Python 3.9, 3.10, 3.11, and 3.12
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/test.yml (1 hunks)
- README.md (1 hunks)
Additional context used
LanguageTool
README.md
[locale-violation] ~5-~5: license must be spelled with a “c” when used as a noun in British English. Use “licence”.
Context: ...+10.3+|+10.4+|+10.5|+11.4&color=C0765A) [
Additional comments not posted (6)
README.md (1)
5-5: Ensure the badge URL is correct and consistent.The badge URL for MariaDB support has been updated to include version 11.4. Verify that the URL is correct and consistent with the format used for other badges.
Tools
LanguageTool
[locale-violation] ~5-~5: license must be spelled with a “c” when used as a noun in British English. Use “licence”.
Context: ...+10.3+|+10.4+|+10.5|+11.4&color=C0765A) [
.github/workflows/test.yml (5)
309-314: LGTM!The configuration for testing with Python 3.8 and MariaDB 11.4 looks good.
315-320: LGTM!The configuration for testing with Python 3.9 and MariaDB 11.4 looks good.
321-326: LGTM!The configuration for testing with Python 3.10 and MariaDB 11.4 looks good.
327-332: LGTM!The configuration for testing with Python 3.11 and MariaDB 11.4 looks good.
333-338: LGTM!The configuration for testing with Python 3.12 and MariaDB 11.4 looks good.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 8 8
Lines 661 661
=======================================
Hits 585 585
Misses 76 76 ☔ View full report in Codecov by Sentry. |
techouse
changed the title
techouse
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- .github/workflows/test.yml (3 hunks)
- README.md (1 hunks)
- pyproject.toml (1 hunks)
- requirements_dev.txt (1 hunks)
- src/sqlite3_to_mysql/transporter.py (2 hunks)
- tests/conftest.py (1 hunks)
- tests/func/sqlite3_to_mysql_test.py (1 hunks)
- tests/func/test_cli.py (9 hunks)
Additional context used
LanguageTool
README.md
[locale-violation] ~5-~5: license must be spelled with a “c” when used as a noun in British English. Use “licence”.
Context: ...+10.3+|+10.4+|+10.5|+11.4&color=C0765A) [
Additional comments not posted (18)
requirements_dev.txt (1)
5-5: Verify compatibility withmysql-connector-pythonversion 9.0.0.Upgrading to a new major version may introduce breaking changes or new features that could affect the application. Ensure that the codebase is compatible with
mysql-connector-python9.0.0 and that all relevant tests pass.pyproject.toml (1)
42-42: Verify compatibility withmysql-connector-pythonversion 9.0.0.Upgrading to a new major version may introduce breaking changes or new features that could affect the application. Ensure that the codebase is compatible with
mysql-connector-python9.0.0 and that all relevant tests pass.README.md (2)
4-4: Update MySQL support badge.The MySQL support badge has been updated to include version 8.4, which improves the clarity of the project's documentation regarding supported MySQL versions.
5-5: Update MariaDB support badge.The MariaDB support badge has been updated to include version 11.4, which improves the clarity of the project's documentation regarding supported MariaDB versions.
Tools
LanguageTool
[locale-violation] ~5-~5: license must be spelled with a “c” when used as a noun in British English. Use “licence”.
Context: ...+10.3+|+10.4+|+10.5|+11.4&color=C0765A) [
tests/conftest.py (1)
296-297: LGTM! But verify the usage of new parameters in the codebase.The code changes are approved.
However, ensure that all calls to
mysql_instanceprovide the new parameters if necessary..github/workflows/test.yml (2)
309-337: New configurations for MariaDB 11.4 look good.The new configurations for MariaDB 11.4 are correctly integrated and follow the existing structure.
459-487: New configurations for MySQL 8.4 look good.The new configurations for MySQL 8.4 are correctly integrated and follow the existing structure.
tests/func/test_cli.py (8)
80-83: Integration of-hand-Parguments looks good.The new arguments are correctly integrated and the test logic remains valid.
106-109: Integration of-hand-Parguments looks good.The new arguments are correctly integrated and the test logic remains valid.
134-137: Integration of-hand-Parguments looks good.The new arguments are correctly integrated and the test logic remains valid.
160-163: Integration of-hand-Parguments looks good.The new arguments are correctly integrated and the test logic remains valid.
187-190: Integration of-hand-Parguments looks good.The new arguments are correctly integrated and the test logic remains valid.
253-256: Integration of-hand-Parguments looks good.The new arguments are correctly integrated and the test logic remains valid.
281-284: Integration of-hand-Parguments looks good.The new arguments are correctly integrated and the test logic remains valid.
Also applies to: 301-304
329-332: Integration of-hand-Parguments looks good.The new arguments are correctly integrated and the test logic remains valid.
tests/func/sqlite3_to_mysql_test.py (1)
351-352: LGTM! But verify the function usage in the codebase.The addition of
charsetandcollationparameters enhances Unicode character support. Ensure that all function calls totest_transfer_transfers_all_tables_in_sqlite_filematch the new signature.Verification successful
No calls to the function
test_transfer_transfers_all_tables_in_sqlite_filewere found.Since there are no calls to this function in the codebase, there are no instances to verify against the new signature.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all function calls to `test_transfer_transfers_all_tables_in_sqlite_file` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type python -A 5 $'test_transfer_transfers_all_tables_in_sqlite_file'Length of output: 104
Script:
#!/bin/bash # Description: Verify all function calls to `test_transfer_transfers_all_tables_in_sqlite_file` match the new signature. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg -A 5 $'test_transfer_transfers_all_tables_in_sqlite_file'Length of output: 481
Script:
#!/bin/bash # Description: Verify all function calls to `test_transfer_transfers_all_tables_in_sqlite_file` match the new signature. # Test: Search for all calls to the function. Expect: Only occurrences of the new signature. rg 'test_transfer_transfers_all_tables_in_sqlite_file\('Length of output: 153
src/sqlite3_to_mysql/transporter.py (2)
110-110: LGTM! But verify the constructor usage in the codebase.The change to set the default collation to
utf8mb4_unicode_cienhances Unicode character support. Ensure that all constructor calls toSQLite3toMySQLmatch the new logic.Verification successful
LGTM! But verify the constructor usage in the codebase.
The change to set the default collation to
utf8mb4_unicode_cienhances Unicode character support. Ensure that all constructor calls toSQLite3toMySQLmatch the new logic.
- Verified multiple instances of
SQLite3toMySQLconstructor usage across test files and the CLI module.- The tests cover various scenarios, ensuring comprehensive coverage.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all constructor calls to `SQLite3toMySQL` match the new logic. # Test: Search for the constructor usage. Expect: Only occurrences of the new logic. rg --type python -A 5 $'SQLite3toMySQL'Length of output: 69
Script:
#!/bin/bash # Description: Verify all constructor calls to `SQLite3toMySQL` match the new logic. # Test: Search for the constructor usage. Expect: Only occurrences of the new logic. rg --type py -A 5 $'SQLite3toMySQL'Length of output: 16989
147-148: LGTM! But verify the method usage in the codebase.The addition of
charsetandcollationparameters in the MySQL connection enhances Unicode character support. Ensure that all calls to_create_databasematch the new logic.
Pull Request Template
Description
Add MariaDB 11.4 and MySQL 8.4 support
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Additional MariaDB 11.4 and MySQL 8.4 specific CI tests have been added.
NOTE: Because of a MySQL 8.4 bug all MySQL 8.4 tests have been marked as experimental which effectively sets
continue-on-error: truefor these tests.Checklist: