Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add last used component and some styling #1662

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rizdarmwn
Copy link

@rizdarmwn rizdarmwn commented Oct 2, 2024

Description

Added last used text for sign in buttons on login page.

Closes #1659

Implementation

Adds a UI state for last used login method, after submit is done, the state updates to whatever the method is, and store it on local storage.

Error/canceled login can still show last used label on the button. Need to know how error is passed through the page.

Tests

Can test with trying to login.

I cannot test all methods, as I don't have oauths keys for everything.

Todos

Screenshots

image

@FlxMgdnz FlxMgdnz requested a review from bjoern-m October 2, 2024 11:37
@rizdarmwn
Copy link
Author

Need advice if there is a better way to put the last used state, for the error/canceled login.

@rizdarmwn rizdarmwn marked this pull request as ready for review October 7, 2024 10:39
@bjoern-m
Copy link
Contributor

bjoern-m commented Oct 9, 2024

Need advice if there is a better way to put the last used state, for the error/canceled login.

Hi @rizdarmwn
I’ve reviewed the issue and it seems like it can’t be easily resolved on the frontend alone and the API doesn’t currently provide the necessary details about the login process (such as the used login method). So, I’d consider your task complete, and we’ll make adjustments to your PR at a later stage.

FYI: @FlxMgdnz

@FlxMgdnz
Copy link
Member

FlxMgdnz commented Oct 9, 2024

/award 750

Copy link

oss-gg bot commented Oct 9, 2024

Awarding rizdarmwn: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/rizdarmwn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

Last used indicator
3 participants