Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test case #2432

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix flaky test case #2432

merged 1 commit into from
Dec 11, 2024

Conversation

dev-rminds
Copy link
Contributor

@dev-rminds dev-rminds commented Dec 11, 2024

Changes description

Case: https://github.com/teamforus/forus-backend/actions/runs/12279849695/attempts/1
Fixed by creating a new fund during the test instead of using the seed data.

Developers checklist

  • Autotests are passed locally
  • Migration rollback works - if there is migration, check rollback
  • Autotests are added:
    • bugfix - unit/feature test for this scenario if possible
    • new small/medium feature - simple feature test for positive scenarios

QA checklist

  • Translations are done
  • Endpoint is fast on dump - if there is new endpoint or changed query, endpoints that are using changed query - working fast on production dump, <2s

@lexlog lexlog merged commit fa3c7e8 into develop Dec 11, 2024
2 checks passed
@lexlog lexlog deleted the tests.fix-flaky-case branch December 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants